Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56d7f894da59a5d699530cb396dbc9400f1836d1
https://github.com/WebKit/WebKit/commit/56d7f894da59a5d699530cb396dbc9400f1836d1
Author: Tim Nguyen <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html
A
LayoutTests/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class.html
M LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log
A
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class-expected.txt
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/dom/Element.cpp
Log Message:
-----------
Make fullscreen elements match the :modal pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=246004
rdar://100782746
Reviewed by Antti Koivisto.
https://w3c.github.io/csswg-drafts/selectors/#modal-state
> For example, the dialog element is :modal when opened with the showModal()
> API.
> Similarly, a :fullscreen element is also :modal when opened with the
> requestFullscreen() API, since this prevents interaction with the rest of the
> page.
We implemented the "prevents interaction with the rest of the page" part in
https://commits.webkit.org/253803@main
Relevant CSSWG discussion: https://github.com/w3c/csswg-drafts/issues/7311
Also, we don't need to worry about the modal dialog in fullscreen mode case,
since the fullscreen API forbids <dialog> elements.
*
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/modal-pseudo-class.html:
Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesModalPseudoClass):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setFullscreenFlag):
Canonical link: https://commits.webkit.org/257572@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
