Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 279c1617bd9634f24ba553470f5feb14627bc95e
https://github.com/WebKit/WebKit/commit/279c1617bd9634f24ba553470f5feb14627bc95e
Author: Ryosuke Niwa <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M LayoutTests/editing/selection/shift-click-expected.txt
A LayoutTests/editing/selection/shift-click-live-range-expected.txt
A LayoutTests/editing/selection/shift-click-live-range.html
M LayoutTests/editing/selection/shift-click.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/page/EventHandler.cpp
Log Message:
-----------
[Live Range Selection] editing/selection/shift-click.html fails
https://bugs.webkit.org/show_bug.cgi?id=248937
Reviewed by Darin Adler.
The bug was caused by handleMousePressEventSingleClick failing to expand the
base appropriately with respect
to granularity when we're about to flip the direction of selection (e.g. base <
extent to extent < base)
as in webkit.org/b/248204. Like https://commits.webkit.org/256964@main, fixed
the bug by expanding the base
when the directionality of selection changes. In particular, reuse & trigger
the very code added in that commit.
* LayoutTests/editing/selection/shift-click-expected.txt:
* LayoutTests/editing/selection/shift-click-live-range-expected.txt: Copied from
LayoutTests/editing/selection/shift-click-expected.txt.
* LayoutTests/editing/selection/shift-click-live-range.html: Copied from
LayoutTests/editing/selection/shift-click.html.
* LayoutTests/editing/selection/shift-click.html: Shift + Click in Windows now
correctly selects trailing whitespace.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
Canonical link: https://commits.webkit.org/257594@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
