Title: [108351] trunk/Source/WebCore
- Revision
- 108351
- Author
- [email protected]
- Date
- 2012-02-21 07:14:49 -0800 (Tue, 21 Feb 2012)
Log Message
Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092
Reviewed by Antti Koivisto.
Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
reported a false warning: 'value$m_ptr' may be used uninitialized in this function
* css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108350 => 108351)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 14:37:51 UTC (rev 108350)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 15:14:49 UTC (rev 108351)
@@ -1,3 +1,16 @@
+2012-02-21 Csaba Osztrogonác <[email protected]>
+
+ Remove stylesheet pointer from StylePropertySet
+ https://bugs.webkit.org/show_bug.cgi?id=79092
+
+ Reviewed by Antti Koivisto.
+
+ Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
+ reported a false warning: 'value$m_ptr' may be used uninitialized in this function
+
+ * css/CSSParser.cpp:
+ (WebCore::parseSimpleLengthValue):
+
2012-02-21 Andreas Kling <[email protected]>
Shrink attribute style property sets after populating them.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (108350 => 108351)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-02-21 14:37:51 UTC (rev 108350)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-02-21 15:14:49 UTC (rev 108351)
@@ -469,7 +469,11 @@
return false;
Document* document = contextStyleSheet->findDocument();
- RefPtr<CSSValue> value = document ? document->cssValuePool()->createValue(number, unit) : CSSPrimitiveValue::create(number, unit);
+ RefPtr<CSSValue> value;
+ if (document)
+ value = document->cssValuePool()->createValue(number, unit);
+ else
+ value = CSSPrimitiveValue::create(number, unit);
declaration->addParsedProperty(CSSProperty(propertyId, value.release(), important));
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
