Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f391c2f826f214bec6c97c56da49016b5d68dfa2
      
https://github.com/WebKit/WebKit/commit/f391c2f826f214bec6c97c56da49016b5d68dfa2
  Author: Antoine Quint <[email protected]>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-color.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/animation/CSSPropertyAnimation.h
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] account for iterationComposite when interpolating custom 
properties
https://bugs.webkit.org/show_bug.cgi?id=249394

Reviewed by Antti Koivisto.

In order to correctly handle iterationComposite when interpolating custom 
properties, we
update CSSPropertyAnimation::propertyRequiresBlendingForAccumulativeIteration() 
to take a
CSSPropertyAnimation::Property as a parameter such that we can accept a custom 
property.

In the implementation we can check for the custom property type to identify 
whether it
requires blending for iterationComposite.

In KeyframeEffect::setAnimatedPropertiesInStyle(), we can then remove the code 
specific
to standard CSS properties when dealing with iterationComposite.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-color.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-length-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::blendProperty):
(WebCore::CSSPropertyAnimation::propertyRequiresBlendingForAccumulativeIteration):
* Source/WebCore/animation/CSSPropertyAnimation.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):

Canonical link: https://commits.webkit.org/257925@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to