- Revision
- 108377
- Author
- [email protected]
- Date
- 2012-02-21 11:33:02 -0800 (Tue, 21 Feb 2012)
Log Message
Remove obsolete float comparison FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=79127
Reviewed by Eric Seidel.
Remove obsolete FIXME comments added back when we were planning to use
floating point units for layout.
No new tests, no code changes.
* page/FrameView.cpp:
(WebCore::FrameView::init):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108376 => 108377)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 19:28:03 UTC (rev 108376)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 19:33:02 UTC (rev 108377)
@@ -1,3 +1,28 @@
+2012-02-21 Emil A Eklund <[email protected]>
+
+ Remove obsolete float comparison FIXMEs
+ https://bugs.webkit.org/show_bug.cgi?id=79127
+
+ Reviewed by Eric Seidel.
+
+ Remove obsolete FIXME comments added back when we were planning to use
+ floating point units for layout.
+
+ No new tests, no code changes.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::init):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::layoutBlock):
+ (WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
+ (WebCore::RenderBlock::getClearDelta):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeLogicalHeight):
+ (WebCore::RenderBox::computeLogicalHeightUsing):
+ (WebCore::RenderBox::computePercentageLogicalHeight):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::ImageQualityController::shouldPaintAtLowQuality):
+
2012-02-21 Alexander Pavlov <[email protected]>
Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
Modified: trunk/Source/WebCore/page/FrameView.cpp (108376 => 108377)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-02-21 19:28:03 UTC (rev 108376)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-02-21 19:33:02 UTC (rev 108377)
@@ -290,8 +290,6 @@
setCanHaveScrollbars(false);
LayoutUnit marginWidth = frameElt->marginWidth();
LayoutUnit marginHeight = frameElt->marginHeight();
- // FIXME: Change to roughlyEquals or >= 0 when we move to floats.
- // See https://bugs.webkit.org/show_bug.cgi?id=66148
if (marginWidth != -1)
setMarginWidth(marginWidth);
if (marginHeight != -1)
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (108376 => 108377)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-02-21 19:28:03 UTC (rev 108376)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-02-21 19:33:02 UTC (rev 108377)
@@ -1517,7 +1517,6 @@
// Make sure the rect is still non-empty after intersecting for overflow above
if (!repaintRect.isEmpty()) {
- // FIXME: Might need rounding once we switch to float, see https://bugs.webkit.org/show_bug.cgi?id=64021
repaintRectangle(repaintRect); // We need to do a partial repaint of our content.
if (hasReflection())
repaintRectangle(reflectedRect(repaintRect));
@@ -1986,7 +1985,6 @@
if (childMarginStart < 0)
startOff += childMarginStart;
newPosition = max(newPosition, startOff); // Let the float sit in the child's margin if it can fit.
- // FIXME: Needs to use epsilon once we switch to float, see https://bugs.webkit.org/show_bug.cgi?id=64021
} else if (startOff != startPosition) {
// The object is shifting to the "end" side of the block. The object might be centered, so we need to
// recalculate our inline direction margins. Note that the containing block content
@@ -4264,8 +4262,6 @@
LayoutUnit newLogicalTop = logicalTop;
while (true) {
LayoutUnit availableLogicalWidthAtNewLogicalTopOffset = availableLogicalWidthForLine(newLogicalTop, false);
- // FIXME: Change to use roughlyEquals when we move to float.
- // See https://bugs.webkit.org/show_bug.cgi?id=66148
if (availableLogicalWidthAtNewLogicalTopOffset == availableLogicalWidthForContent(newLogicalTop))
return newLogicalTop - logicalTop;
@@ -4286,8 +4282,6 @@
child->setMarginLeft(childOldMarginLeft);
child->setMarginRight(childOldMarginRight);
- // FIXME: Change to use roughlyEquals when we move to float.
- // See https://bugs.webkit.org/show_bug.cgi?id=66148
if (childLogicalWidthAtNewLogicalTopOffset <= availableLogicalWidthAtNewLogicalTopOffset)
return newLogicalTop - logicalTop;
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (108376 => 108377)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-02-21 19:28:03 UTC (rev 108376)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-02-21 19:33:02 UTC (rev 108377)
@@ -2037,7 +2037,6 @@
LayoutUnit heightResult;
if (checkMinMaxHeight) {
heightResult = computeLogicalHeightUsing(styleToUse->logicalHeight());
- // FIXME: Use < 0 or roughlyEquals when we move to float, see https://bugs.webkit.org/show_bug.cgi?id=66148
if (heightResult == -1)
heightResult = logicalHeight();
LayoutUnit minH = computeLogicalHeightUsing(styleToUse->logicalMinHeight()); // Leave as -1 if unset.
@@ -2096,7 +2095,6 @@
logicalHeight = h.value();
else if (h.isPercent())
logicalHeight = computePercentageLogicalHeight(h);
- // FIXME: Use < 0 or roughlyEquals when we move to float, see https://bugs.webkit.org/show_bug.cgi?id=66148
if (logicalHeight != -1) {
logicalHeight = computeBorderBoxLogicalHeight(logicalHeight);
return logicalHeight;
@@ -2163,7 +2161,6 @@
else if (cbstyle->logicalHeight().isPercent() && !isPositionedWithSpecifiedHeight) {
// We need to recur and compute the percentage height for our containing block.
result = cb->computePercentageLogicalHeight(cbstyle->logicalHeight());
- // FIXME: Use < 0 or roughlyEquals when we move to float, see https://bugs.webkit.org/show_bug.cgi?id=66148
if (result != -1)
result = cb->computeContentBoxLogicalHeight(result);
} else if (cb->isRenderView() || (cb->isBody() && document()->inQuirksMode()) || isPositionedWithSpecifiedHeight) {
@@ -2178,7 +2175,6 @@
// always. Note we could only hit this case by recurring into computePercentageLogicalHeight on a positioned containing block.
result = cb->computeContentBoxLogicalHeight(cb->availableLogicalHeight());
- // FIXME: Use < 0 or roughlyEquals when we move to float, see https://bugs.webkit.org/show_bug.cgi?id=66148
if (result != -1) {
result = height.calcValue(result);
if (includeBorderPadding) {
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (108376 => 108377)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2012-02-21 19:28:03 UTC (rev 108376)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2012-02-21 19:33:02 UTC (rev 108377)
@@ -168,8 +168,6 @@
const AffineTransform& currentTransform = context->getCTM();
bool contextIsScaled = !currentTransform.isIdentityOrTranslationOrFlipped();
- // FIXME: Change to use roughlyEquals when we move to float.
- // See https://bugs.webkit.org/show_bug.cgi?id=66148
if (!contextIsScaled && size == imageSize) {
// There is no scale in effect. If we had a scale in effect before, we can just remove this object from the list.
removeLayer(object, innerMap, layer);
@@ -192,8 +190,6 @@
// If this is the first time resizing this image, or its size is the
// same as the last resize, draw at high res, but record the paint
// size and set the timer.
- // FIXME: Change to use roughlyEquals when we move to float.
- // See https://bugs.webkit.org/show_bug.cgi?id=66148
if (isFirstResize || oldSize == size) {
restartTimer();
set(object, innerMap, layer, size);
