Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: da41e97dfc9eea940f2602e7efe8954c78f09492
https://github.com/WebKit/WebKit/commit/da41e97dfc9eea940f2602e7efe8954c78f09492
Author: Tim Horton <[email protected]>
Date: 2022-12-15 (Thu, 15 Dec 2022)
Changed paths:
M Source/JavaScriptCore/DerivedSources.make
M Source/WebCore/DerivedSources.make
M Source/WebKit/DerivedSources.make
M Tools/DumpRenderTree/DerivedSources.make
M Tools/WebKitTestRunner/DerivedSources.make
Log Message:
-----------
IDL and Sandbox preprocessor invocation doesn't have defines from
GCC_PREPROCESSOR_DEFINITIONS
https://bugs.webkit.org/show_bug.cgi?id=249363
rdar://103381924
Reviewed by Elliott Williams.
* Source/JavaScriptCore/DerivedSources.make:
* Source/WebCore/DerivedSources.make:
* Source/WebKit/DerivedSources.make:
* Tools/DumpRenderTree/DerivedSources.make:
* Tools/WebKitTestRunner/DerivedSources.make:
Include defines from GCC_PREPROCESSOR_DEFINITIONS when calling out
to the preprocessor for IDL and Sandbox files. This can in some cases
cause mismatches between the features enabled in C++ code and in IDLs
or sandbox profiles.
Adopt Make's addprefix instead of calling out to Perl to add prefixes,
because GCC_PREPROCESSOR_DEFINITIONS can sometimes be empty, and our Perl script
would emit a lone `-D` in that case, breaking the build. Also adopt for other
variables.
Also set RELEASE_WITHOUT_OPTIMIZATIONS; otherwise in release builds,
GCC_PREPROCESSOR_DEFINITIONS gets us -NDEBUG, but not -O3, and Platform.h
complains about the unexpected mismatch.
Canonical link: https://commits.webkit.org/257972@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
