Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6ff73fa8a9f8a8196001a303e29a06e1bbd294e
      
https://github.com/WebKit/WebKit/commit/e6ff73fa8a9f8a8196001a303e29a06e1bbd294e
  Author: Alan Baradlay <[email protected]>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC][hanging punctuation] InlineContentBreaker::ContinuousContent should 
support leading hanging content
https://bugs.webkit.org/show_bug.cgi?id=249551

Reviewed by Antti Koivisto.

This is in preparation for supporting "hanging-punctuation" property.
InlineContentBreaker::ContinuousContent is input to the line breaking logic.
As leading hanging content is considered as "negative horizontal margin",
it should be excluded when measuring the candidate content for fit.
No functionality change yet.

(This patch also removes some std::optional<InlineLayoutUnit> complexity.)
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendTextContent):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendTrailingHangingContent):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendLeadingHangingContent):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::reset):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):

Canonical link: https://commits.webkit.org/258066@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to