Title: [108412] trunk
Revision
108412
Author
[email protected]
Date
2012-02-21 16:19:26 -0800 (Tue, 21 Feb 2012)

Log Message

equalIgnoringNullity() only comparing half the bytes for equality
https://bugs.webkit.org/show_bug.cgi?id=79135

Reviewed by Adam Barth.

Source/_javascript_Core:

* wtf/text/StringImpl.h:
(WTF::equalIgnoringNullity):

LayoutTests:

* http/tests/security/xssAuditor/script-tag.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (108411 => 108412)


--- trunk/LayoutTests/ChangeLog	2012-02-22 00:12:09 UTC (rev 108411)
+++ trunk/LayoutTests/ChangeLog	2012-02-22 00:19:26 UTC (rev 108412)
@@ -1,3 +1,12 @@
+2012-02-21  Tom Sepez  <[email protected]>
+
+        equalIgnoringNullity() only comparing half the bytes for equality
+        https://bugs.webkit.org/show_bug.cgi?id=79135
+
+        Reviewed by Adam Barth.
+
+        * http/tests/security/xssAuditor/script-tag.html:
+
 2012-02-21  James Robinson  <[email protected]>
 
         [chromium] Update chromium expectations for accessibility/aria-invalid.html

Modified: trunk/LayoutTests/http/tests/security/xssAuditor/script-tag.html (108411 => 108412)


--- trunk/LayoutTests/http/tests/security/xssAuditor/script-tag.html	2012-02-22 00:12:09 UTC (rev 108411)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/script-tag.html	2012-02-22 00:19:26 UTC (rev 108412)
@@ -9,7 +9,7 @@
 </script>
 </head>
 <body>
-<iframe src=""
+<iframe src=""
 </iframe>
 </body>
 </html>

Modified: trunk/Source/_javascript_Core/ChangeLog (108411 => 108412)


--- trunk/Source/_javascript_Core/ChangeLog	2012-02-22 00:12:09 UTC (rev 108411)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-22 00:19:26 UTC (rev 108412)
@@ -1,3 +1,13 @@
+2012-02-21  Tom Sepez  <[email protected]>
+
+        equalIgnoringNullity() only comparing half the bytes for equality
+        https://bugs.webkit.org/show_bug.cgi?id=79135
+
+        Reviewed by Adam Barth.
+
+        * wtf/text/StringImpl.h:
+        (WTF::equalIgnoringNullity):
+
 2012-02-21  Roland Takacs  <[email protected]>
 
         Unnecessary preprocessor macros in MainThread.h/cpp

Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.h (108411 => 108412)


--- trunk/Source/_javascript_Core/wtf/text/StringImpl.h	2012-02-22 00:12:09 UTC (rev 108411)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.h	2012-02-22 00:19:26 UTC (rev 108412)
@@ -735,7 +735,7 @@
         return !a.size();
     if (a.size() != b->length())
         return false;
-    return !memcmp(a.data(), b->characters(), b->length());
+    return !memcmp(a.data(), b->characters(), b->length() * sizeof(UChar));
 }
 
 WTF_EXPORT_PRIVATE int codePointCompare(const StringImpl*, const StringImpl*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to