Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7c22044657df3c1fc11a5c7bc6f4e2068a984e71
https://github.com/WebKit/WebKit/commit/7c22044657df3c1fc11a5c7bc6f4e2068a984e71
Author: Simon Fraser <[email protected]>
Date: 2022-12-22 (Thu, 22 Dec 2022)
Changed paths:
M
LayoutTests/compositing/canvas/hidpi-canvas-backing-store-invalidation-2-expected.txt
M LayoutTests/compositing/fixed-with-fixed-layout-expected.txt
M
LayoutTests/compositing/layer-creation/zoomed-clip-intersection-expected.txt
M LayoutTests/editing/editable-region/iframe-expected.txt
M
LayoutTests/editing/editable-region/iframe-without-editable-region-expected.txt
M LayoutTests/fast/scrolling/mac/event-region-subframe-expected.txt
M LayoutTests/fast/scrolling/mac/event-region-subscroller-frame-expected.txt
M
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt
M
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt
M
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt
M
LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt
M
LayoutTests/platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt
M
LayoutTests/platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt
M LayoutTests/platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt
M
LayoutTests/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt
M LayoutTests/tiled-drawing/tile-size-slow-zoomed-expected.txt
M LayoutTests/tiled-drawing/tiled-drawing-zoom-expected.txt
M LayoutTests/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt
M Source/WebCore/page/PageOverlayController.cpp
M Source/WebCore/page/PageOverlayController.h
M Source/WebCore/platform/graphics/GraphicsLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h
Log Message:
-----------
Set the RenderView's layer's anchorPoint to 0,0
https://bugs.webkit.org/show_bug.cgi?id=249517
<rdar://problem/103528523>
Reviewed by Matt Woodrow.
Zooming code gets easier if we always give the RenderView's layer an anchor
point of [0,0], instead of the default [0.5,0.5].
This layer is only ever transformed via pinch-zooming, so this does not affect
web-exposed behavior. The transform can be set
on both the m_graphicsLayer and m_contentsContainmentLayer (see calls to
setAppliesPageScale()).
To avoid the need for > 600 layout test rebaselines, add code to
RenderLayerBacking::shouldDumpPropertyForLayer() to
control whether to dump the anchor point on the RenderView's layer; we'll only
dump it if it has something other
than the default 0,0 value. Undoing this hack is tracked by webkit.org/b/249600.
Rebaseline some tests that show that zooming already left a 0,0 anchor point on
the layers.
*
LayoutTests/compositing/canvas/hidpi-canvas-backing-store-invalidation-2-expected.txt:
* LayoutTests/compositing/fixed-with-fixed-layout-expected.txt:
* LayoutTests/compositing/layer-creation/zoomed-clip-intersection-expected.txt:
*
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
*
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
*
LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
*
LayoutTests/platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
* LayoutTests/platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
*
LayoutTests/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt:
* LayoutTests/tiled-drawing/tile-size-slow-zoomed-expected.txt:
* LayoutTests/tiled-drawing/tiled-drawing-zoom-expected.txt:
* LayoutTests/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
* Source/WebCore/page/PageOverlayController.cpp:
(WebCore::PageOverlayController::shouldDumpPropertyForLayer const):
* Source/WebCore/page/PageOverlayController.h:
* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldDumpPropertyForLayer const):
* Source/WebCore/rendering/RenderLayerCompositor.h:
Canonical link: https://commits.webkit.org/258284@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
