Title: [108424] trunk/Source/WebCore
- Revision
- 108424
- Author
- [email protected]
- Date
- 2012-02-21 17:23:24 -0800 (Tue, 21 Feb 2012)
Log Message
Remove FIXME from resolve-supplemental.pl
https://bugs.webkit.org/show_bug.cgi?id=79160
Reviewed by Adam Barth.
The IDL attribute checker has been enabled in all build systems.
This patch removes FIXME in resolve-supplemental.pl.
Also, this patch improves a comment in IDLAttributes.txt.
No tests. No change in behavior.
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/resolve-supplemental.pl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108423 => 108424)
--- trunk/Source/WebCore/ChangeLog 2012-02-22 01:19:11 UTC (rev 108423)
+++ trunk/Source/WebCore/ChangeLog 2012-02-22 01:23:24 UTC (rev 108424)
@@ -1,3 +1,19 @@
+2012-02-21 Kentaro Hara <[email protected]>
+
+ Remove FIXME from resolve-supplemental.pl
+ https://bugs.webkit.org/show_bug.cgi?id=79160
+
+ Reviewed by Adam Barth.
+
+ The IDL attribute checker has been enabled in all build systems.
+ This patch removes FIXME in resolve-supplemental.pl.
+ Also, this patch improves a comment in IDLAttributes.txt.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/IDLAttributes.txt:
+ * bindings/scripts/resolve-supplemental.pl:
+
2012-02-21 Emil A Eklund <[email protected]>
Add FractionalLayoutRect for sub-pixel layout
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (108423 => 108424)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2012-02-22 01:19:11 UTC (rev 108423)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2012-02-22 01:23:24 UTC (rev 108424)
@@ -1,8 +1,10 @@
#
# This file describes all IDL attributes.
# If any IDL file uses an IDL attribute not listed below, the WebKit build will fail.
-# If you want to add a new IDL attribute, you need to add it to this file
-# and the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL).
+# If you want to add a new IDL attribute, you need to
+# (1) add the IDL attribute to this file
+# (2) add the explanation to the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL)
+# (3) add test cases to run-bindings-tests
#
# The syntax of this file is as follows:
# - You can write one IDL attribute per one line.
Modified: trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl (108423 => 108424)
--- trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl 2012-02-22 01:19:11 UTC (rev 108423)
+++ trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl 2012-02-22 01:23:24 UTC (rev 108424)
@@ -63,14 +63,10 @@
$interfaceNameToIdlFile{fileparse(basename($idlFile), ".idl")} = $fullPath;
}
-# FIXME: After enabling the IDL attribute checker on all build systems
-# we can remove the if statement.
-if ($idlAttributesFile) {
- # Runs the IDL attribute checker.
- my $idlAttributes = loadIDLAttributes($idlAttributesFile);
- foreach my $idlFile (keys %documents) {
- checkIDLAttributes($idlAttributes, $documents{$idlFile}, basename($idlFile));
- }
+# Runs the IDL attribute checker.
+my $idlAttributes = loadIDLAttributes($idlAttributesFile);
+foreach my $idlFile (keys %documents) {
+ checkIDLAttributes($idlAttributes, $documents{$idlFile}, basename($idlFile));
}
# Resolves [Supplemental=XXX] dependencies.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
