Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f61cf23abe063f69ce6408c47a6454825ce011e8
https://github.com/WebKit/WebKit/commit/f61cf23abe063f69ce6408c47a6454825ce011e8
Author: Ahmad Saleem <[email protected]>
Date: 2023-01-03 (Tue, 03 Jan 2023)
Changed paths:
A LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt
A LayoutTests/editing/selection/skip-non-editable-rtl.html
M Source/WebCore/editing/VisiblePosition.cpp
Log Message:
-----------
Incorrect caret movement in some RTL contenteditable elements
Incorrect caret movement in some RTL contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=249905
Reviewed by Ryosuke Niwa.
This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.
Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=183843
Content editable when mixed in direction RTL, it was not moving caret because
editing boundary was not calculated correctly. In RTL scenario, nodes
need to be calculated from after or before for left and right respectively.
Based on the direction of the block calculates appropriate editing boundary.
* Source/WebCore/editing/VisiblePosition.cpp:
(VisiblePosition::left): Remove 'FIXME' and respect direction
(VisiblePosition::right): Remove 'FIXME' and respect direction
* LayoutTests/editing/selection/skip-non-editable-rtl.html: Add Test Case
* LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt: Add Test
Case Expectation
Canonical link: https://commits.webkit.org/258398@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
