Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80f4f4ee7deb62df8465a1678d21346fab7c3cb8
      
https://github.com/WebKit/WebKit/commit/80f4f4ee7deb62df8465a1678d21346fab7c3cb8
  Author: Brent Fulgham <[email protected]>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    A 
LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit-expected.txt
    A 
LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
    M Source/WebKit/WebProcess/Network/WebSocketChannelManager.h

  Log Message:
  -----------
  Lower per-process websocket connection limits to match other browser behavior
https://bugs.webkit.org/show_bug.cgi?id=247100
<rdar://90340929>

Reviewed by Chris Dumez.

Chrome and Firefox place an upper bound on the number of connections that a 
single web page may have open at the same time.

We should follow this behavior to avoid a poorly written web page impacting 
system performance. We will use Chrome's larger
limit to reduce the likelihood of web compatibility issues.

Tested by a new test: 
http/tests/websocket/tests/hybi/multiple-connections-limit.html

* 
LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit-expected.txt:
 Added.
* LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit.html: 
Added.
* Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::connect): Check open connections and fail the 
connection attempt if we exceed them.
* Source/WebKit/WebProcess/Network/WebSocketChannelManager.h:
(WebKit::WebSocketChannelManager::hasReachedSocketLimit const): Added.

Canonical link: https://commits.webkit.org/258488@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to