Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 547de625ee39cf066893b8dafd70fa534f132791
https://github.com/WebKit/WebKit/commit/547de625ee39cf066893b8dafd70fa534f132791
Author: Ahmad Saleem <[email protected]>
Date: 2023-01-11 (Wed, 11 Jan 2023)
Changed paths:
M LayoutTests/editing/editability/empty-document-stylewithcss.html
M LayoutTests/editing/execCommand/reset-values-after-navigation-expected.txt
M LayoutTests/editing/execCommand/reset-values-after-navigation.html
M LayoutTests/editing/execCommand/style-with-css-expected.txt
M LayoutTests/editing/execCommand/style-with-css.html
M Source/WebCore/editing/EditorCommand.cpp
Log Message:
-----------
queryCommandValue("stylewithcss") should always return an empty string
queryCommandValue("stylewithcss") should always return an empty string
https://bugs.webkit.org/show_bug.cgi?id=250397
Reviewed by Ryosuke Niwa.
This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and
Web-Specification.
Merge -
https://chromium.googlesource.com/chromium/src.git/+/57c2207020be6758153102c90902b4b49781744e
This patch introduces a new function, which returns emptyString and then use in
the CommandMap
for the default value of "StyleWithCSS", which is aligned with
web-specification.
This change does not have any dedicated test since the change already has WPT
coverage.
* Source/WebCore/editing/EditorCommand.cpp:
(valueAsEmptyString): New function
(CommandMaps): Update default from "valueNull" to "valueAsEmptyString"
* LayoutTests/editing/editability/empty-document-stylewithcss.html: Rebaselined
* LayoutTests/editing/execCommand/reset-values-after-navigation-expected.txt:
Ditto
* LayoutTests/editing/execCommand/reset-values-after-navigation.html: Ditto
* LayoutTests/editing/execCommand/style-with-css-expected.txt: Ditto
* LayoutTests/editing/execCommand/style-with-css.html: Ditto
Canonical link: https://commits.webkit.org/258777@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
