Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cd2a1fbef4618f12a8b08ad464162fa4fef51061
https://github.com/WebKit/WebKit/commit/cd2a1fbef4618f12a8b08ad464162fa4fef51061
Author: Vitaly Dyachkov <[email protected]>
Date: 2023-01-11 (Wed, 11 Jan 2023)
Changed paths:
M Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectCollectionAtspi.cpp
M
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
Log Message:
-----------
[ATSPI] Make `Atspi::Role` enum class
https://bugs.webkit.org/show_bug.cgi?id=250452
Reviewed by Michael Catanzaro.
When working with ATSPI-related code, there are several different role
types. There are - ARIA role, `WebCore::AccessibilityRole`, and
`Atspi::Role`.
Currently `Atspi::Role` is implemented as `enum`, which makes it hard to
distinguish it from other role types when it's used as an argument or
a return type:
`std::optional<unsigned> AccessibilityObjectAtspi::effectiveRole() const`
Using `enum class` instead should make such code more readable:
`std::optional<Atspi::Role> AccessibilityObjectAtspi::effectiveRole() const`
* Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::atspiRole):
(WebCore::AccessibilityObjectAtspi::effectiveRole const):
(WebCore::AccessibilityObjectAtspi::role const):
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectCollectionAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::CollectionMatchRule::CollectionMatchRule):
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::roleValueToString):
Canonical link: https://commits.webkit.org/258788@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
