[webkit-changes] [WebKit/WebKit] d3e21f: element's validity state checks shouldn...</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22EWS%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">EWS</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20230115" rel="nofollow">Sun, 15 Jan 2023 07:31:38 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: d3e21f7e246becf92fa8087859f304a1653e8d5a <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/d3e21f7e246becf92fa8087859f304a1653e8d5a">https://github.com/WebKit/WebKit/commit/d3e21f7e246becf92fa8087859f304a1653e8d5a</a> Author: Alexey Shvayka <ashva...@apple.com> Date: 2023-01-15 (Sun, 15 Jan 2023)</pre><pre> Changed paths: M LayoutTests/fast/forms/ValidityState-tooLong-textarea-expected.txt M LayoutTests/fast/forms/ValidityState-tooLong-textarea.html A LayoutTests/fast/forms/ValidityState-tooShort-textarea-expected.txt A LayoutTests/fast/forms/ValidityState-tooShort-textarea.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-validity-valueMissing-inside-datalist-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-validity-valueMissing-inside-datalist.html M Source/WebCore/html/HTMLTextAreaElement.cpp Log Message: ----------- <textarea> element's validity state checks shouldn't be dependent on willValidate() <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=250453">https://bugs.webkit.org/show_bug.cgi?id=250453</a> Reviewed by Darin Adler. This change aligns <textarea> element's validity checks with the spec, Blink / Gecko, and <input> element's counterparts: * valueMissing() [1] depends on mutability concept rather than "barred from constaint validation", which are observably different only if the <textarea> is a descendant of a <datalist> element; * tooShort() [2] / tooLong() [3] prose doesn't mention any requirement for willValidate(). Also this patch enables a follow-up revamp of updateWillValidateAndValidity() by untangling computeValidity() and computeWillValidate() (currently the former implicitly depends on the latter). Tests: fast/forms/ValidityState-tooShort-textarea.html fast/forms/ValidityState-tooLong-textarea.html imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-validity-valueMissing-inside-datalist.html [1] <a rel="nofollow" href="https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:suffering-from-being-missing">https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:suffering-from-being-missing</a> [2] <a rel="nofollow" href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#setting-minimum-input-length-requirements:-the-minlength-attribute:suffering-from-being-too-short">https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#setting-minimum-input-length-requirements:-the-minlength-attribute:suffering-from-being-too-short</a> [3] <a rel="nofollow" href="https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#limiting-user-input-length:-the-maxlength-attribute:suffering-from-being-too-long">https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#limiting-user-input-length:-the-maxlength-attribute:suffering-from-being-too-long</a> * LayoutTests/fast/forms/ValidityState-tooLong-textarea-expected.txt: * LayoutTests/fast/forms/ValidityState-tooLong-textarea.html: * LayoutTests/fast/forms/ValidityState-tooShort-textarea-expected.txt: Added. * LayoutTests/fast/forms/ValidityState-tooShort-textarea.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-validity-valueMissing-inside-datalist-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-validity-valueMissing-inside-datalist.html: Added. * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::valueMissing const): (WebCore::HTMLTextAreaElement::tooShort const): (WebCore::HTMLTextAreaElement::tooLong const): Canonical link: <a rel="nofollow" href="https://commits.webkit.org/258928@main">https://commits.webkit.org/258928@main</a> _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org <a rel="nofollow" href="https://lists.webkit.org/mailman/listinfo/webkit-changes">https://lists.webkit.org/mailman/listinfo/webkit-changes</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg193854.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#193855">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#193855">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg193856.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] d3e21f: <textarea> element's validity state checks shouldn..."> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/7a5daf-d3e21f@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg193855.html"> <input type="submit" value=" EWS "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+d3e21f%5C%3A+%3Ctextarea%3E+element%27s+validity+state+checks+shouldn...%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg193854.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg193856.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/7a5daf-d3e21f@github.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9eb8eb3f7dc0b23b',t:'MTc3NjA2NzAzNg=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>