Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 599d00ac6774a1c036faa6f6adf3f96fb95d337f
https://github.com/WebKit/WebKit/commit/599d00ac6774a1c036faa6f6adf3f96fb95d337f
Author: Youenn Fablet <[email protected]>
Date: 2023-01-18 (Wed, 18 Jan 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/sample-worker-interceptor.js
M
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/loader/FetchOptions.h
M Source/WebCore/loader/ThreadableLoader.cpp
M Source/WebCore/workers/WorkerScriptLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
REGRESSION (Safari 16): Service worker clientId is empty for web worker
fetches
https://bugs.webkit.org/show_bug.cgi?id=245425
rdar://problem/100368228
Reviewed by Chris Dumez.
After introducing correct matching of service worker registration for worker
loads, we correctly filled resultingClientId to the worker context id.
As per
https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script,
we need to set clientId to the context Id creating the worker.
To do so, we introduce resultingClientId as a FetchOptions so that we can set
both clientId and resultingClientId when doing a load.
Set resultingClientId in DocumentLoader and set both clientId and
resultingClientId for workers.
Update networking process code to pass clientId and resultingClientId when
starting a fetch event.
Relanding after verifying through A/B testing that it is not regressing
speedometer.
Covered by newly added test.
*
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/sample-worker-interceptor.js:
*
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::loadMainResource):
* Source/WebCore/loader/FetchOptions.h:
(WebCore::FetchOptions::isolatedCopy const):
(WebCore::FetchOptions::isolatedCopy):
(WebCore::FetchOptions::FetchOptions):
(WebCore::FetchOptions::decodePersistent):
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadAsynchronously):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::transferToNewWebProcess):
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::startFetch):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::controlClient):
(WebKit::WebSWServerConnection::createFetchTask):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/259031@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
