Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ca671233e2e274c939d425fab3318c712a79a5b
https://github.com/WebKit/WebKit/commit/6ca671233e2e274c939d425fab3318c712a79a5b
Author: Patrick Angle <[email protected]>
Date: 2023-01-23 (Mon, 23 Jan 2023)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h
M Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h
M Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm
Log Message:
-----------
Web Inspector: `extensionHostWebView` and `webView` for
_WKRemoteWebInspectorViewController be nil, but is not marked as nullable
https://bugs.webkit.org/show_bug.cgi?id=250874
rdar://92478255
Reviewed by Brian Weinstein.
The web view for an inspector may be nil if we have already torn down the
window, as can the inspector.
* Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
- Add `_Nullable` annotations.
* Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController _setDiagnosticLoggingDelegate:]):
(-[_WKRemoteWebInspectorViewController
registerExtensionWithID:extensionBundleIdentifier:displayName:completionHandler:]):
(-[_WKRemoteWebInspectorViewController
showExtensionTabWithIdentifier:completionHandler:]):
(-[_WKRemoteWebInspectorViewController
navigateExtensionTabWithIdentifier:toURL:completionHandler:]):
- Remove nullability annotations from implementation file to match other files
where we only annotate headers. Otherwise
we'd have to mark the return types as nullable here as well.
Canonical link: https://commits.webkit.org/259258@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
