Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4bbaaeffdd01c947764f4645eb48b7a55db6ae89
https://github.com/WebKit/WebKit/commit/4bbaaeffdd01c947764f4645eb48b7a55db6ae89
Author: Jean-Yves Avenard <[email protected]>
Date: 2023-01-27 (Fri, 27 Jan 2023)
Changed paths:
M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
Log Message:
-----------
ASSERTION FAILED: m_element in WebFullScreenManager::setAnimatingFullScreen
https://bugs.webkit.org/show_bug.cgi?id=251247
rdar://104728830
Reviewed by Youenn Fablet.
Calling
[self _manager]->didExitFullScreen();
will prevent:
[self _manager]->setAnimatingFullScreen(false);
>From doing anything as a pointer gets cleared. Considering that outside of
>this code the pattern
to exit full screen is:
[self _manager]->setAnimatingFullScreen(false);
[self _manager]->didExitFullScreen();
We make the code pattern to exit fullscreen consistent.
No test was included because TestWebKitAPI is not allowed to enter fullscreen
or PiP as its not
a "real" application.
* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController
finishedExitFullScreenAnimationAndExitImmediately:]):
Canonical link: https://commits.webkit.org/259513@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
