Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8298a862fed61d92b48e246066f4968c43fe8bcb
https://github.com/WebKit/WebKit/commit/8298a862fed61d92b48e246066f4968c43fe8bcb
Author: Tadeu Zagallo <[email protected]>
Date: 2023-01-30 (Mon, 30 Jan 2023)
Changed paths:
M Source/WebGPU/WGSL/EntryPointRewriter.cpp
M Websites/webkit.org/demos/webgpu/scripts/hello-triangle.js
Log Message:
-----------
[WGSL] Always visit vertex entry point output
https://bugs.webkit.org/show_bug.cgi?id=251268
<rdar://problem/104744731>
Reviewed by Myles C. Maxfield.
Right now, in order to translate the struct member attributes correctly to
metal,
we check whether a struct is being used as an output of the vertex entry point
(in order to use the `[[user()]]` attributes to connect it with the fragment
entry
point. This is a bit hacky, but works for now. However, the bug was that we
didn't
perform this check if we didn't need to rewrite the entry point's input
arguments,
but the two things are unrelated. This had broken the hello-triangle demo.
Also fixed the FIXME in the example since we now support binary add.
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::rewrite):
(WGSL::EntryPointRewriter::checkReturnType):
* Websites/webkit.org/demos/webgpu/scripts/hello-triangle.js:
(async helloTriangle):
Canonical link: https://commits.webkit.org/259546@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
