Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 165e0db5c7299e734a4a6c04f157a835d3ee7452
https://github.com/WebKit/WebKit/commit/165e0db5c7299e734a4a6c04f157a835d3ee7452
Author: Simon Fraser <[email protected]>
Date: 2023-02-01 (Wed, 01 Feb 2023)
Changed paths:
M Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig
M Tools/DumpRenderTree/mac/Info.plist
M Tools/Scripts/webkitpy/port/mac.py
Log Message:
-----------
Clear DumpRenderTree and WebKitTestRunner defaults before running tests
https://bugs.webkit.org/show_bug.cgi?id=251397
rdar://104838472
Reviewed by Jonathan Bedard.
Historically DumpRenderTree had no bundleID specified, so would save
NSUserDefaults using
"DumpRenderTree". WebKitTestRunner, on the other hand, was correctly set up to
use
"com.apple.WebKit.WebKitTestRunner". This patch gives DumpRenderTree a bundleID
with
a "com.apple.WebKit" prefix.
These bundleIDs matter because webkitpy uses them to clear NSUserDefaults
before test runs;
this worked fine for DumpRenderTree, but failed for WebKitTestRunner because
the bundleID
was incorrect. Fix that in mac.py, and use the new bundleID
com.apple.WebKit.DumpRenderTree too.
Generally failing to clear NSUserDefaults before testing isn't an issue, but
defaults like WebCoreLogging
can get saved into NSUserDefaults if you run WebKitTestRunner directly with
logging arguments, so clearing
before running tests is useful in that scenario.
* Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* Tools/DumpRenderTree/mac/Info.plist:
* Tools/Scripts/webkitpy/port/mac.py:
(MacPort.reset_preferences):
Canonical link: https://commits.webkit.org/259687@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
