Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0cecded94ccc26c1c6dd30b4d906ba7a4881d70c
https://github.com/WebKit/WebKit/commit/0cecded94ccc26c1c6dd30b4d906ba7a4881d70c
Author: Philippe Normand <ph...@igalia.com>
Date: 2023-02-10 (Fri, 10 Feb 2023)
Changed paths:
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
Log Message:
-----------
[GStreamer][WebAudio] Minor clean-ups in source element
https://bugs.webkit.org/show_bug.cgi?id=251988
Reviewed by Xabier Rodriguez-Calvar.
The buffer allocation function doesn't need to return an optional<>. The
RenderAndPushFrames has no
reason to take a moved ref of the element. The state-change logic should
perform upwards transitions
before chaining-up to the parent class, and downward transitions afterwards.
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcAllocateBuffers):
(webKitWebAudioSrcRenderAndPushFrames):
(webKitWebAudioSrcRenderIteration):
(webKitWebAudioSrcChangeState):
Canonical link: https://commits.webkit.org/260103@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
