Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 644136eded86c788741c1e011630d0a1c56554a7
https://github.com/WebKit/WebKit/commit/644136eded86c788741c1e011630d0a1c56554a7
Author: Sihui Liu <[email protected]>
Date: 2023-02-16 (Thu, 16 Feb 2023)
Changed paths:
M
LayoutTests/storage/filesystemaccess/resources/sync-access-handle-read-write.js
M
LayoutTests/storage/filesystemaccess/sync-access-handle-read-write-worker-expected.txt
M
LayoutTests/storage/filesystemaccess/sync-access-handle-storage-limit-worker.html
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp
M Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp
Log Message:
-----------
FileSystemSyncAccessHandle should not cast return value of
FileSystem::seekFile to int
https://bugs.webkit.org/show_bug.cgi?id=252145
rdar://105373703
Reviewed by Youenn Fablet.
FileSystemSyncAccessHandle currently casts the return value of seek from long
long to int, which would make read() and
write() return error when the offset might be accepted by FileSystem
functions(e.g. 4GB), so let's make sure we check
long long value of the result. Also, this patch adds a 16GB limit on each file
to avoid offset getting too big. This
value might be changed later.
*
LayoutTests/storage/filesystemaccess/resources/sync-access-handle-read-write.js:
(async test):
*
LayoutTests/storage/filesystemaccess/sync-access-handle-read-write-worker-expected.txt:
*
LayoutTests/storage/filesystemaccess/sync-access-handle-storage-limit-worker.html:
* Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp:
(WebCore::FileSystemSyncAccessHandle::read):
(WebCore::FileSystemSyncAccessHandle::write):
* Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::FileSystemStorageHandle::FileSystemStorageHandle):
(WebKit::FileSystemStorageHandle::requestNewCapacityForSyncAccessHandle):
Canonical link: https://commits.webkit.org/260377@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
