Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a3294dbf52d08e036a8e55928267bb778e250d6
      
https://github.com/WebKit/WebKit/commit/3a3294dbf52d08e036a8e55928267bb778e250d6
  Author: Tim Nguyen <[email protected]>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    A LayoutTests/fullscreen/event-listener-prefixed-unprefixed-expected.html
    A LayoutTests/fullscreen/event-listener-prefixed-unprefixed.html
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  REGRESSION (257658@main): Maximize full screen button fails to minimize once 
in full screen on trailers.apple.com
https://bugs.webkit.org/show_bug.cgi?id=252414
rdar://105144719

Reviewed by Chris Dumez.

The website was broken because it listens for both unprefixed & prefixed APIs 
to toggle between states, which ends up toggling the
wrong number of times.

To fix this, only emit unprefixed API when there is no listener for the 
prefixed API.

* LayoutTests/fullscreen/event-listener-prefixed-unprefixed-expected.html: 
Added.
* LayoutTests/fullscreen/event-listener-prefixed-unprefixed.html: Added.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::dispatchEventForNode):

Canonical link: https://commits.webkit.org/260651@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to