Diff
Modified: trunk/Source/WebCore/ChangeLog (108729 => 108730)
--- trunk/Source/WebCore/ChangeLog 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebCore/ChangeLog 2012-02-24 06:24:47 UTC (rev 108730)
@@ -1,3 +1,20 @@
+2012-02-23 Andy Estes <[email protected]>
+
+ Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
+ https://bugs.webkit.org/show_bug.cgi?id=79433
+
+ Reviewed by Dan Bernstein.
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitClose):
+ (WebCore::Document::visualUpdatesAllowed):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+ (WebCore::Settings::setSuppressesIncrementalRendering):
+ (WebCore::Settings::suppressesIncrementalRendering):
+ (Settings):
+
2012-02-23 Erik Arvidsson <[email protected]>
Rename DOMWindow to Window in the bindings
Modified: trunk/Source/WebCore/dom/Document.cpp (108729 => 108730)
--- trunk/Source/WebCore/dom/Document.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebCore/dom/Document.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -2331,7 +2331,7 @@
}
// If painting and compositing layer updates were suppressed pending the load event, do these actions now.
- if (renderer() && settings() && settings()->suppressIncrementalRendering()) {
+ if (renderer() && settings() && settings()->suppressesIncrementalRendering()) {
#if USE(ACCELERATED_COMPOSITING)
view()->updateCompositingLayers();
#endif
@@ -5437,7 +5437,7 @@
bool Document::visualUpdatesAllowed() const
{
return !settings()
- || !settings()->suppressIncrementalRendering()
+ || !settings()->suppressesIncrementalRendering()
|| loadEventFinished();
}
Modified: trunk/Source/WebCore/page/Settings.cpp (108729 => 108730)
--- trunk/Source/WebCore/page/Settings.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebCore/page/Settings.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -228,7 +228,7 @@
, m_mediaPlaybackRequiresUserGesture(false)
, m_mediaPlaybackAllowsInline(true)
, m_passwordEchoEnabled(false)
- , m_suppressIncrementalRendering(false)
+ , m_suppressesIncrementalRendering(false)
, m_backspaceKeyNavigationEnabled(true)
, m_visualWordMovementEnabled(false)
#if ENABLE(VIDEO_TRACK)
Modified: trunk/Source/WebCore/page/Settings.h (108729 => 108730)
--- trunk/Source/WebCore/page/Settings.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebCore/page/Settings.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -483,8 +483,8 @@
void setPasswordEchoEnabled(bool flag) { m_passwordEchoEnabled = flag; }
bool passwordEchoEnabled() const { return m_passwordEchoEnabled; }
- void setSuppressIncrementalRendering(bool flag) { m_suppressIncrementalRendering = flag; }
- bool suppressIncrementalRendering() const { return m_suppressIncrementalRendering; }
+ void setSuppressesIncrementalRendering(bool flag) { m_suppressesIncrementalRendering = flag; }
+ bool suppressesIncrementalRendering() const { return m_suppressesIncrementalRendering; }
void setBackspaceKeyNavigationEnabled(bool flag) { m_backspaceKeyNavigationEnabled = flag; }
bool backspaceKeyNavigationEnabled() const { return m_backspaceKeyNavigationEnabled; }
@@ -669,7 +669,7 @@
bool m_mediaPlaybackRequiresUserGesture : 1;
bool m_mediaPlaybackAllowsInline : 1;
bool m_passwordEchoEnabled : 1;
- bool m_suppressIncrementalRendering : 1;
+ bool m_suppressesIncrementalRendering : 1;
bool m_backspaceKeyNavigationEnabled : 1;
bool m_visualWordMovementEnabled : 1;
Modified: trunk/Source/WebKit/mac/ChangeLog (108729 => 108730)
--- trunk/Source/WebKit/mac/ChangeLog 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-02-24 06:24:47 UTC (rev 108730)
@@ -1,3 +1,23 @@
+2012-02-23 Andy Estes <[email protected]>
+
+ Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
+ https://bugs.webkit.org/show_bug.cgi?id=79433
+
+ Reviewed by Dan Bernstein.
+
+ * WebCoreSupport/WebInspectorClient.mm:
+ (-[WebInspectorWindowController init]):
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setSuppressesIncrementalRendering:]):
+ (-[WebPreferences suppressesIncrementalRendering]):
+ (-[WebPreferences setSuppressIncrementalRendering:]):
+ (-[WebPreferences suppressIncrementalRendering]):
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2012-02-22 Hajime Morrita <[email protected]>
NOTIFICATIONS should be implemented as PageSupplement
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (108729 => 108730)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-02-24 06:24:47 UTC (rev 108730)
@@ -240,7 +240,7 @@
[preferences setMinimumFontSize:0];
[preferences setMinimumLogicalFontSize:9];
[preferences setPlugInsEnabled:NO];
- [preferences setSuppressIncrementalRendering:YES];
+ [preferences setSuppressesIncrementalRendering:YES];
[preferences setTabsToLinks:NO];
[preferences setUserStyleSheetEnabled:NO];
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (108729 => 108730)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -118,6 +118,7 @@
#define WebKitShouldDisplayCaptionsPreferenceKey @"WebKitShouldDisplayCaptions"
#define WebKitShouldDisplayTextDescriptionsPreferenceKey @"WebKitShouldDisplayTextDescriptions"
#define WebKitNotificationsEnabledKey @"WebKitNotificationsEnabled"
+#define WebKitSuppressesIncrementalRenderingKey @"WebKitSuppressesIncrementalRendering"
// These are private both because callers should be using the cover methods and because the
// cover methods themselves are private.
@@ -132,7 +133,6 @@
#define WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey @"WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey"
#define WebKitEditingBehaviorPreferenceKey @"WebKitEditingBehavior"
#define WebKitUsePreHTML5ParserQuirksKey @"WebKitUsePreHTML5ParserQuirks"
-#define WebKitSuppressIncrementalRenderingKey @"WebKitSuppressIncrementalRendering"
#define WebKitBackspaceKeyNavigationEnabledKey @"WebKitBackspaceKeyNavigationEnabled"
// CoreGraphics deferred updates are disabled if WebKitEnableCoalescedUpdatesPreferenceKey is set
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.h (108729 => 108730)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -431,4 +431,17 @@
*/
- (WebCacheModel)cacheModel;
+/*!
+ @method setSuppressesIncrementalRendering:
+ @param suppressesIncrementalRendering YES to suppress incremental rendering;
+ NO otherwise.
+*/
+- (void)setSuppressesIncrementalRendering:(BOOL)suppressesIncrementalRendering;
+
+/*!
+ @method suppressesIncrementalRendering
+ @result YES if the WebView suppresses incremental rendering; NO otherwise.
+*/
+- (BOOL)suppressesIncrementalRendering;
+
@end
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (108729 => 108730)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2012-02-24 06:24:47 UTC (rev 108730)
@@ -389,7 +389,7 @@
[NSNumber numberWithBool:NO], WebKitMediaPlaybackRequiresUserGesturePreferenceKey,
[NSNumber numberWithBool:YES], WebKitMediaPlaybackAllowsInlinePreferenceKey,
[NSNumber numberWithBool:NO], WebKitWebAudioEnabledPreferenceKey,
- [NSNumber numberWithBool:NO], WebKitSuppressIncrementalRenderingKey,
+ [NSNumber numberWithBool:NO], WebKitSuppressesIncrementalRenderingKey,
[NSNumber numberWithBool:YES], WebKitBackspaceKeyNavigationEnabledKey,
[NSNumber numberWithBool:NO], WebKitShouldDisplaySubtitlesPreferenceKey,
[NSNumber numberWithBool:NO], WebKitShouldDisplayCaptionsPreferenceKey,
@@ -808,6 +808,17 @@
return [self _integerValueForKey:WebKitCacheModelPreferenceKey];
}
+
+- (void)setSuppressesIncrementalRendering:(BOOL)suppressesIncrementalRendering
+{
+ [self _setBoolValue:suppressesIncrementalRendering forKey:WebKitSuppressesIncrementalRenderingKey];
+}
+
+- (BOOL)suppressesIncrementalRendering
+{
+ return [self _boolValueForKey:WebKitSuppressesIncrementalRenderingKey];
+}
+
@end
@implementation WebPreferences (WebPrivate)
@@ -1595,12 +1606,12 @@
- (void)setSuppressIncrementalRendering:(BOOL)flag
{
- [self _setBoolValue:flag forKey:WebKitSuppressIncrementalRenderingKey];
+ [self _setBoolValue:flag forKey:WebKitSuppressesIncrementalRenderingKey];
}
- (BOOL)suppressIncrementalRendering
{
- return [self _boolValueForKey:WebKitSuppressIncrementalRenderingKey];
+ return [self _boolValueForKey:WebKitSuppressesIncrementalRenderingKey];
}
- (void)setBackspaceKeyNavigationEnabled:(BOOL)flag
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (108729 => 108730)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -274,6 +274,7 @@
- (void)setHixie76WebSocketProtocolEnabled:(BOOL)flag;
- (BOOL)isHixie76WebSocketProtocolEnabled;
+// Deprecated. You should use [setS|s]uppressesIncrementalRendering in WebPreferences.h instead.
- (void)setSuppressIncrementalRendering:(BOOL)flag;
- (BOOL)suppressIncrementalRendering;
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (108729 => 108730)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2012-02-24 06:24:47 UTC (rev 108730)
@@ -1507,7 +1507,7 @@
#endif
settings->setMediaPlaybackRequiresUserGesture([preferences mediaPlaybackRequiresUserGesture]);
settings->setMediaPlaybackAllowsInline([preferences mediaPlaybackAllowsInline]);
- settings->setSuppressIncrementalRendering([preferences suppressIncrementalRendering]);
+ settings->setSuppressesIncrementalRendering([preferences suppressesIncrementalRendering]);
settings->setBackspaceKeyNavigationEnabled([preferences backspaceKeyNavigationEnabled]);
settings->setMockScrollbarsEnabled([preferences mockScrollbarsEnabled]);
Modified: trunk/Source/WebKit2/ChangeLog (108729 => 108730)
--- trunk/Source/WebKit2/ChangeLog 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-24 06:24:47 UTC (rev 108730)
@@ -1,3 +1,23 @@
+2012-02-23 Andy Estes <[email protected]>
+
+ Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
+ https://bugs.webkit.org/show_bug.cgi?id=79433
+
+ Reviewed by Dan Bernstein.
+
+ * Shared/WebPreferencesStore.h:
+ (WebKit):
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetSuppressesIncrementalRendering):
+ (WKPreferencesGetSuppressesIncrementalRendering):
+ * UIProcess/API/C/WKPreferences.h:
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::createInspectorPageGroup):
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2012-02-23 Mario Sanchez Prada <[email protected]>
[GTK] Wrong signal name on emission in WebKitWindowProperties.cpp
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (108729 => 108730)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -99,7 +99,7 @@
macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false) \
macro(WebAudioEnabled, webAudioEnabled, Bool, bool, false) \
macro(ApplicationChromeModeEnabled, applicationChromeMode, Bool, bool, false) \
- macro(SuppressIncrementalRendering, suppressIncrementalRendering, Bool, bool, false) \
+ macro(SuppressesIncrementalRendering, suppressesIncrementalRendering, Bool, bool, false) \
macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, true) \
macro(CaretBrowsingEnabled, caretBrowsingEnabled, Bool, bool, false) \
macro(ShouldDisplaySubtitles, shouldDisplaySubtitles, Bool, bool, false) \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (108729 => 108730)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -678,14 +678,14 @@
return toImpl(preferencesRef)->applicationChromeMode();
}
-void WKPreferencesSetSuppressIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled)
+void WKPreferencesSetSuppressesIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled)
{
- toImpl(preferencesRef)->setSuppressIncrementalRendering(enabled);
+ toImpl(preferencesRef)->setSuppressesIncrementalRendering(enabled);
}
-bool WKPreferencesGetSuppressIncrementalRendering(WKPreferencesRef preferencesRef)
+bool WKPreferencesGetSuppressesIncrementalRendering(WKPreferencesRef preferencesRef)
{
- return toImpl(preferencesRef)->suppressIncrementalRendering();
+ return toImpl(preferencesRef)->suppressesIncrementalRendering();
}
void WKPreferencesSetBackspaceKeyNavigationEnabled(WKPreferencesRef preferencesRef, bool enabled)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h (108729 => 108730)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h 2012-02-24 06:24:47 UTC (rev 108730)
@@ -170,8 +170,8 @@
WK_EXPORT bool WKPreferencesGetWebAudioEnabled(WKPreferencesRef preferencesRef);
// Defaults to false
-WK_EXPORT void WKPreferencesSetSuppressIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled);
-WK_EXPORT bool WKPreferencesGetSuppressIncrementalRendering(WKPreferencesRef preferencesRef);
+WK_EXPORT void WKPreferencesSetSuppressesIncrementalRendering(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetSuppressesIncrementalRendering(WKPreferencesRef preferencesRef);
// Defaults to true
WK_EXPORT void WKPreferencesSetBackspaceKeyNavigationEnabled(WKPreferencesRef preferencesRef, bool enabled);
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (108729 => 108730)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -55,7 +55,7 @@
#endif
pageGroup->preferences()->setApplicationChromeModeEnabled(true);
- pageGroup->preferences()->setSuppressIncrementalRendering(true);
+ pageGroup->preferences()->setSuppressesIncrementalRendering(true);
return pageGroup.release();
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (108729 => 108730)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -537,7 +537,7 @@
// Notify the UIProcess.
webPage->send(Messages::WebPageProxy::DidFirstLayoutForFrame(m_frame->frameID(), InjectedBundleUserMessageEncoder(userData.get())));
- if (m_frame == m_frame->page()->mainWebFrame() && !webPage->corePage()->settings()->suppressIncrementalRendering())
+ if (m_frame == m_frame->page()->mainWebFrame() && !webPage->corePage()->settings()->suppressesIncrementalRendering())
webPage->drawingArea()->setLayerTreeStateIsFrozen(false);
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (108729 => 108730)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-24 06:21:32 UTC (rev 108729)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-24 06:24:47 UTC (rev 108730)
@@ -1926,7 +1926,7 @@
#endif
settings->setApplicationChromeMode(store.getBoolValueForKey(WebPreferencesKey::applicationChromeModeKey()));
- settings->setSuppressIncrementalRendering(store.getBoolValueForKey(WebPreferencesKey::suppressIncrementalRenderingKey()));
+ settings->setSuppressesIncrementalRendering(store.getBoolValueForKey(WebPreferencesKey::suppressesIncrementalRenderingKey()));
settings->setBackspaceKeyNavigationEnabled(store.getBoolValueForKey(WebPreferencesKey::backspaceKeyNavigationEnabledKey()));
settings->setCaretBrowsingEnabled(store.getBoolValueForKey(WebPreferencesKey::caretBrowsingEnabledKey()));
