Title: [108743] trunk/Source/WebCore
- Revision
- 108743
- Author
- [email protected]
- Date
- 2012-02-24 00:28:43 -0800 (Fri, 24 Feb 2012)
Log Message
Web Inspector: exception in front-end on selecting an element in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=79447
Fixed a typo in method name and added a check that selected node has
corresponding heap snapshot object before adding that object to the console
as $0 entry.
Reviewed by Pavel Feldman.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108742 => 108743)
--- trunk/Source/WebCore/ChangeLog 2012-02-24 08:20:51 UTC (rev 108742)
+++ trunk/Source/WebCore/ChangeLog 2012-02-24 08:28:43 UTC (rev 108743)
@@ -1,3 +1,17 @@
+2012-02-23 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: exception in front-end on selecting an element in heap snapshot
+ https://bugs.webkit.org/show_bug.cgi?id=79447
+
+ Fixed a typo in method name and added a check that selected node has
+ corresponding heap snapshot object before adding that object to the console
+ as $0 entry.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/DetailedHeapshotView.js:
+ (WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):
+
2012-02-23 Pavel Feldman <[email protected]>
Web Inspector: hide color picker upon panel switch.
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (108742 => 108743)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-24 08:20:51 UTC (rev 108742)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-24 08:28:43 UTC (rev 108743)
@@ -848,7 +848,8 @@
_inspectedObjectChanged: function(event)
{
var selectedNode = event.target.selectedNode;
- ConsoleAgent.addInspectedObject(selectedNode.snapshotNodeId);
+ if (selectedNode instanceof WebInspector.HeapSnapshotGenericObjectNode)
+ ConsoleAgent.addInspectedHeapObject(selectedNode.snapshotNodeId);
},
_setRetainmentDataGridSource: function(nodeItem)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
