Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aa13aa32a9839363ae62683ab88fca4841bb9d35
https://github.com/WebKit/WebKit/commit/aa13aa32a9839363ae62683ab88fca4841bb9d35
Author: Tyler Wilcock <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInterface.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
AX: Remove boundingBoxRect and computedLabel from the AXCoreObject interface
https://bugs.webkit.org/show_bug.cgi?id=253289
rdar://problem/106175101
Reviewed by Andres Gonzalez.
These functions are only necessary for `AccessibilityObject`s, not
`AXIsolatedObject`s.
This patch also makes calls to `performFunctionOnMainThread` type their lamdba
with `AccessibilityObject*` instead
of `AXCoreObject*`. `performFunctionOnMainThread` calls
`AXIsolatedObject::associatedAXObject()`, which returns an
`AccessibilityObject*`,
so let's use the stronger typing to make the code more clear and to help
devirtualization optimizations.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::boundingBoxRect const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::pixelSnappedBoundingBoxRect const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::setSelectedChildren):
(WebCore::AXIsolatedObject::setARIAGrabbed):
(WebCore::AXIsolatedObject::setIsExpanded):
(WebCore::AXIsolatedObject::scrollToMakeVisible const):
(WebCore::AXIsolatedObject::scrollToMakeVisibleWithSubFocus const):
(WebCore::AXIsolatedObject::scrollToGlobalPoint const):
(WebCore::AXIsolatedObject::setSelected):
(WebCore::AXIsolatedObject::setSelectedRows):
(WebCore::AXIsolatedObject::setFocused):
(WebCore::AXIsolatedObject::setSelectedText):
(WebCore::AXIsolatedObject::setSelectedTextRange):
(WebCore::AXIsolatedObject::getOrRetrievePropertyValue):
(WebCore::AXIsolatedObject::makeRangeVisible):
(WebCore::AXIsolatedObject::increment):
(WebCore::AXIsolatedObject::decrement):
(WebCore::AXIsolatedObject::computedLabel): Deleted.
(WebCore::AXIsolatedObject::boundingBoxRect const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/261210@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
