Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 565fae35562a90c0c3956c51f21b3b02f38e8b63
https://github.com/WebKit/WebKit/commit/565fae35562a90c0c3956c51f21b3b02f38e8b63
Author: Tadeu Zagallo <[email protected]>
Date: 2023-03-07 (Tue, 07 Mar 2023)
Changed paths:
M Source/WebGPU/WGSL/AST/ASTForward.h
M Source/WebGPU/WGSL/AST/ASTNode.h
M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
M Source/WebGPU/WGSL/AST/ASTStringDumper.h
M Source/WebGPU/WGSL/AST/ASTTypeName.h
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTVisitor.h
M Source/WebGPU/WGSL/EntryPointRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
R Source/WebGPU/WGSL/ResolveTypeReferences.cpp
R Source/WebGPU/WGSL/ResolveTypeReferences.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/WGSL.cpp
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
Log Message:
-----------
[WGSL] Remove ResolveTypeReferences pass
https://bugs.webkit.org/show_bug.cgi?id=253311
rdar://106194074
Reviewed by Myles C. Maxfield.
Originally this pass was added to resolve which types referred to structs, which
was needed for the RewriteEntryPoints pass. Now that the type checker is a
little
more capable we can use the types inferred from it instead and simplify the
code.
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTNode.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTTypeName.h:
(WGSL::AST::NamedTypeName::name):
(isType):
(WGSL::AST::NamedTypeName::maybeResolvedReference const): Deleted.
(WGSL::AST::NamedTypeName::resolveTypeReference): Deleted.
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::rewrite):
(WGSL::EntryPointRewriter::collectStructs):
(WGSL::EntryPointRewriter::checkReturnType):
(WGSL::EntryPointRewriter::visit):
(WGSL::EntryPointRewriter::getResolvedType): Deleted.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
* Source/WebGPU/WGSL/ResolveTypeReferences.cpp: Removed.
* Source/WebGPU/WGSL/ResolveTypeReferences.h: Removed.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepareImpl):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/261322@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
