Title: [108822] trunk/Source/WebKit2
- Revision
- 108822
- Author
- [email protected]
- Date
- 2012-02-24 10:51:25 -0800 (Fri, 24 Feb 2012)
Log Message
requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
about the permission level.
https://bugs.webkit.org/show_bug.cgi?id=79494
Reviewed by Jon Honeycutt.
Invoke the callback in the case where the permission level is known and no message is sent
to the UI Process.
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (108821 => 108822)
--- trunk/Source/WebKit2/ChangeLog 2012-02-24 18:51:11 UTC (rev 108821)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-24 18:51:25 UTC (rev 108822)
@@ -1,3 +1,17 @@
+2012-02-24 Jessie Berlin <[email protected]>
+
+ requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
+ about the permission level.
+ https://bugs.webkit.org/show_bug.cgi?id=79494
+
+ Reviewed by Jon Honeycutt.
+
+ Invoke the callback in the case where the permission level is known and no message is sent
+ to the UI Process.
+
+ * WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
+ (WebKit::NotificationPermissionRequestManager::startRequest):
+
2012-02-24 Jocelyn Turcotte <[email protected]>
[Qt] Signal and property cleanup in QQuickWebView
Modified: trunk/Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp (108821 => 108822)
--- trunk/Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp 2012-02-24 18:51:11 UTC (rev 108821)
+++ trunk/Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp 2012-02-24 18:51:25 UTC (rev 108822)
@@ -62,8 +62,10 @@
void NotificationPermissionRequestManager::startRequest(SecurityOrigin* origin, PassRefPtr<VoidCallback> callback)
{
#if ENABLE(NOTIFICATIONS)
- if (permissionLevel(origin) != NotificationPresenter::PermissionNotAllowed)
+ if (permissionLevel(origin) != NotificationPresenter::PermissionNotAllowed) {
+ callback->handleEvent();
return;
+ }
uint64_t requestID = generateRequestID();
m_originToIDMap.set(origin, requestID);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
