Title: [108833] trunk/Source/WebKit/chromium
- Revision
- 108833
- Author
- [email protected]
- Date
- 2012-02-24 11:40:00 -0800 (Fri, 24 Feb 2012)
Log Message
[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
https://bugs.webkit.org/show_bug.cgi?id=79296
Reviewed by Kenneth Russell.
The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.
* public/platform/WebGraphicsContext3D.h:
(WebKit):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/FakeWebGraphicsContext3D.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (108832 => 108833)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-24 19:39:01 UTC (rev 108832)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-24 19:40:00 UTC (rev 108833)
@@ -1,3 +1,18 @@
+2012-02-24 James Robinson <[email protected]>
+
+ [chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
+ https://bugs.webkit.org/show_bug.cgi?id=79296
+
+ Reviewed by Kenneth Russell.
+
+ The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
+ WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.
+
+ * public/platform/WebGraphicsContext3D.h:
+ (WebKit):
+ * tests/CCLayerTreeHostImplTest.cpp:
+ * tests/FakeWebGraphicsContext3D.h:
+
2012-02-23 James Robinson <[email protected]>
[chromium] Move Web*Layer* headers into Platform
Modified: trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h (108832 => 108833)
--- trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h 2012-02-24 19:39:01 UTC (rev 108832)
+++ trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h 2012-02-24 19:40:00 UTC (rev 108833)
@@ -64,9 +64,6 @@
// Typedef for server-side objects like OpenGL textures and program objects.
typedef WGC3Duint WebGLId;
-// FIXME: We shouldn't mention WebView in platform.
-class WebView;
-
// This interface abstracts the operations performed by the
// GraphicsContext3D in order to implement WebGL. Nearly all of the
// methods exposed on this interface map directly to entry points in
@@ -141,9 +138,6 @@
// This destructor needs to be public so that using classes can destroy instances if initialization fails.
virtual ~WebGraphicsContext3D() {}
- // This function is deprecated and will be removed soon.
- virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return false; }
-
// Makes the OpenGL context current on the current thread. Returns true on
// success.
virtual bool makeContextCurrent() = 0;
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (108832 => 108833)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-02-24 19:39:01 UTC (rev 108832)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-02-24 19:40:00 UTC (rev 108833)
@@ -422,8 +422,6 @@
public:
BlendStateTrackerContext() : m_blend(false) { }
- virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return true; }
-
virtual void enable(WGC3Denum cap)
{
if (cap == GraphicsContext3D::BLEND)
@@ -632,8 +630,6 @@
public:
ReshapeTrackerContext() : m_reshapeCalled(false) { }
- virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return true; }
-
virtual void reshape(int width, int height)
{
m_reshapeCalled = true;
@@ -673,8 +669,6 @@
class PartialSwapTrackerContext : public FakeWebGraphicsContext3D {
public:
- virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return true; }
-
virtual void postSubBufferCHROMIUM(int x, int y, int width, int height)
{
m_partialSwapRect = IntRect(x, y, width, height);
Modified: trunk/Source/WebKit/chromium/tests/FakeWebGraphicsContext3D.h (108832 => 108833)
--- trunk/Source/WebKit/chromium/tests/FakeWebGraphicsContext3D.h 2012-02-24 19:39:01 UTC (rev 108832)
+++ trunk/Source/WebKit/chromium/tests/FakeWebGraphicsContext3D.h 2012-02-24 19:40:00 UTC (rev 108833)
@@ -35,8 +35,6 @@
// All operations are no-ops (returning 0 if necessary).
class FakeWebGraphicsContext3D : public WebGraphicsContext3D {
public:
- virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) { return false; }
-
virtual bool makeContextCurrent() { return true; }
virtual int width() { return 0; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
