Title: [108837] trunk/Tools
- Revision
- 108837
- Author
- [email protected]
- Date
- 2012-02-24 12:42:07 -0800 (Fri, 24 Feb 2012)
Log Message
webkitpy: config_unittest is sensitive to other tests that might've already run
https://bugs.webkit.org/show_bug.cgi?id=79382
Reviewed by Adam Barth.
If another test runs prior to config_unittest and pokes the
cached configuration, the first test in config_unittest might
fail; the tearDown() will then allow subsequent tests to pass.
Clearing the configuration prior to each test makes things
slightly slower but safer.
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.setUp):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (108836 => 108837)
--- trunk/Tools/ChangeLog 2012-02-24 20:36:45 UTC (rev 108836)
+++ trunk/Tools/ChangeLog 2012-02-24 20:42:07 UTC (rev 108837)
@@ -1,3 +1,19 @@
+2012-02-24 Dirk Pranke <[email protected]>
+
+ webkitpy: config_unittest is sensitive to other tests that might've already run
+ https://bugs.webkit.org/show_bug.cgi?id=79382
+
+ Reviewed by Adam Barth.
+
+ If another test runs prior to config_unittest and pokes the
+ cached configuration, the first test in config_unittest might
+ fail; the tearDown() will then allow subsequent tests to pass.
+ Clearing the configuration prior to each test makes things
+ slightly slower but safer.
+
+ * Scripts/webkitpy/layout_tests/port/config_unittest.py:
+ (ConfigTest.setUp):
+
2012-02-24 David Kilzer <[email protected]>
Use xcrun to find compiler paths for Generate Derived Sources build phase script
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py (108836 => 108837)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py 2012-02-24 20:36:45 UTC (rev 108836)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py 2012-02-24 20:42:07 UTC (rev 108837)
@@ -40,6 +40,9 @@
class ConfigTest(unittest.TestCase):
+ def setUp(self):
+ config.clear_cached_configuration()
+
def tearDown(self):
config.clear_cached_configuration()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
