Diff
Modified: trunk/LayoutTests/ChangeLog (108838 => 108839)
--- trunk/LayoutTests/ChangeLog 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/ChangeLog 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,3 +1,31 @@
+2012-02-24 Adrienne Walker <[email protected]>
+
+ Fix flaky tests by removing call to dumpResourceResponseMIMETypes
+ https://bugs.webkit.org/show_bug.cgi?id=79505
+
+ Reviewed by Daniel Bates.
+
+ It appears to be a race condition (on Chromium at least) between when
+ script executes and the style sheet resource response occurs. This
+ prevents some of the text to be output if the response occurs before
+ the call to set the flag to dump responses. Since the tests themselves
+ already test the results of loading stylesheets properly, this extra
+ text is superfluous and can be removed.
+
+ This change modifies all tests using link-load-utilities.js to dump
+ stylesheet resource responses. Other tests are using
+ dumpResponseResponseMIMEType, but for things other than stylesheets.
+
+ * fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
+ * fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
+ * fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
+ * fast/dom/HTMLLinkElement/link-onload-expected.txt:
+ * fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
+ * fast/dom/HTMLLinkElement/link-onload2-expected.txt:
+ * fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
+ * fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
+ * fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
+
2012-02-24 Elliot Poger <[email protected]>
Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,5 +1,3 @@
-stylesheet-with-existent-and-non-existent-import.css has MIME type text/css
-stylesheet.css has MIME type text/css
This tests that an Error event is fired at an HTML Link element when its style sheet fails to load an @import'ed style sheet (regardless of whether it successfully loaded another @import'ed style sheet). This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
PASS Fired Error event.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet-with-non-existent-import.css has MIME type text/css
This tests that an Error event is fired at an HTML Link element when its style sheet fails to load an @import'ed style sheet. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
PASS Fired Error event.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet.css has MIME type text/css
This tests that a Load event for an HTML Link element comes before the Load event for the window. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
PASS Fired Load event at link.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet.css has MIME type text/css
This tests that a Load event is fired at an HTML Link element once it loads a style sheet. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
PASS Fired Load event.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,5 +1,3 @@
-stylesheet-with-import.css has MIME type text/css
-stylesheet.css has MIME type text/css
This tests that a Load event is fired at an HTML Link element once all @import'ed stylesheets are loaded by a style sheet. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
PASS Fired Load event.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload2-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload2-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload2-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet.css has MIME type text/css
This tests that we fire two Load events on a page with two HTML Link elements and that both events are fired before the Load event for the window is dispatched. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
PASS Fired 2 Load events.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet.css has MIME type text/css
This tests that a Load event is fired at a programmatically inserted HTML Link element once it loads its style sheet. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
PASS Fired Load event.
Modified: trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/link-load-utilities.js (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/link-load-utilities.js 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/link-load-utilities.js 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,6 +1,5 @@
if (window.layoutTestController) {
layoutTestController.dumpAsText();
- layoutTestController.dumpResourceResponseMIMETypes();
layoutTestController.waitUntilDone();
}
Modified: trunk/LayoutTests/fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt (108838 => 108839)
--- trunk/LayoutTests/fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt 2012-02-24 20:45:39 UTC (rev 108838)
+++ trunk/LayoutTests/fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt 2012-02-24 21:06:27 UTC (rev 108839)
@@ -1,4 +1,3 @@
-stylesheet.css has MIME type text/css
This tests that a Error event is fired at an HTML Style element whose @import style sheet failed to load. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
PASS Error event fired.
