Title: [108866] trunk/Source/_javascript_Core
- Revision
- 108866
- Author
- [email protected]
- Date
- 2012-02-24 16:23:38 -0800 (Fri, 24 Feb 2012)
Log Message
DFG support for op_new_regexp should be enabled
https://bugs.webkit.org/show_bug.cgi?id=79538
Reviewed by Oliver Hunt.
No performance change.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGCommon.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (108865 => 108866)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-25 00:22:15 UTC (rev 108865)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-25 00:23:38 UTC (rev 108866)
@@ -1,3 +1,16 @@
+2012-02-24 Filip Pizlo <[email protected]>
+
+ DFG support for op_new_regexp should be enabled
+ https://bugs.webkit.org/show_bug.cgi?id=79538
+
+ Reviewed by Oliver Hunt.
+
+ No performance change.
+
+ * dfg/DFGCapabilities.h:
+ (JSC::DFG::canCompileOpcode):
+ * dfg/DFGCommon.h:
+
2012-02-24 Michael Saboff <[email protected]>
ASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
Modified: trunk/Source/_javascript_Core/dfg/DFGCapabilities.h (108865 => 108866)
--- trunk/Source/_javascript_Core/dfg/DFGCapabilities.h 2012-02-25 00:22:15 UTC (rev 108865)
+++ trunk/Source/_javascript_Core/dfg/DFGCapabilities.h 2012-02-25 00:23:38 UTC (rev 108866)
@@ -153,21 +153,9 @@
case op_throw_reference_error:
case op_call:
case op_construct:
- return true;
-
- // Opcodes we support conditionally. Enabling these opcodes currently results in
- // performance regressions. Each node that we disable under restrictions has a
- // comment describing what we know about the regression so far.
-
- // Regresses string-validate-input, probably because it uses comparisons (< and >)
- // on strings, which currently will cause speculation failures in some cases.
case op_new_regexp:
-#if DFG_ENABLE(RESTRICTIONS)
- return false;
-#else
return true;
-#endif
-
+
default:
return false;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.h (108865 => 108866)
--- trunk/Source/_javascript_Core/dfg/DFGCommon.h 2012-02-25 00:22:15 UTC (rev 108865)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.h 2012-02-25 00:23:38 UTC (rev 108866)
@@ -69,8 +69,6 @@
#define DFG_ENABLE_OSR_ENTRY ENABLE(DFG_JIT)
// Generate stats on how successful we were in making use of the DFG jit, and remaining on the hot path.
#define DFG_ENABLE_SUCCESS_STATS 0
-// Used to enable conditionally supported opcodes that currently result in performance regressions.
-#define DFG_ENABLE_RESTRICTIONS 1
// Enable verification that the DFG is able to insert code for control flow edges.
#define DFG_ENABLE_EDGE_CODE_VERIFICATION 0
// Pretend that all variables in the top-level code block got captured. Great
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
