Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54c0a441a4a1db892ba3f87e4c5048608058b31d
      
https://github.com/WebKit/WebKit/commit/54c0a441a4a1db892ba3f87e4c5048608058b31d
  Author: Tadeu Zagallo <[email protected]>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WGSL] Temporarily disable early compilation
https://bugs.webkit.org/show_bug.cgi?id=254224
<rdar://problem/107008408>

Reviewed by Myles C. Maxfield and Mike Wyrzykowski.

Since early compilation is an optimization, and using deferred compilation can 
be
helpful for catching bugs where we make irreversible changes to the AST (such as
the one in EntryPointRewriter fixed in this patch), temporarily disable it until
we have deferred compilation fully working. The plan is to refactor the API to 
make
the AST immutable, but this is helpful in the meantime.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::collectParameters):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):

Canonical link: https://commits.webkit.org/261979@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to