Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 934f8ed073f26981d56de40e1848240732b7500c
https://github.com/WebKit/WebKit/commit/934f8ed073f26981d56de40e1848240732b7500c
Author: Antoine Quint <[email protected]>
Date: 2023-03-22 (Wed, 22 Mar 2023)
Changed paths:
M
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled-expected.txt
M
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html
M LayoutTests/platform/mac/TestExpectations
Log Message:
-----------
REGRESSION(261912@main): [ macOS ]
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html
is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=254245
rdar://107028528
Reviewed by Dean Jackson.
This test regressed because it assumed the mute button would be located in the
bottoms bar
with controls sized with a width of 250px. However, in 261912@main, we enforced
correctly
removing the container to the right of the time control if there isn't enough
room to show
the ellipsis button at all.
We fix this test by making the controls wider and also make it more robust by
not making
assumption on timing of the first test condition being true and using
shouldBecomeEqual()
instead, wrapper in a promise for code clarity.
*
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled-expected.txt:
*
LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html:
* LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/261991@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
