Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ea376b24d5bd5ed0d5649a940cc60fdf5862e5f
https://github.com/WebKit/WebKit/commit/0ea376b24d5bd5ed0d5649a940cc60fdf5862e5f
Author: Gerald Squelart <[email protected]>
Date: 2023-03-24 (Fri, 24 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/attachment/cocoa/wide-attachment-class-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-class.html
A
LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-dom-expected.txt
A LayoutTests/fast/attachment/cocoa/wide-attachment-dom.html
A
LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon.html
A
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension-expected.html
A
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-id-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-id.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-save-event-expected.txt
A LayoutTests/fast/attachment/cocoa/wide-attachment-save-event.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-uti-expected.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-uti.html
A
LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action-expected-mismatch.html
A LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action.html
A
LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process-expected.html
A LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process.html
A
LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
A LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic.html
A
LayoutTests/fast/attachment/mac/wide-attachment-type-attribute-expected.html
A LayoutTests/fast/attachment/mac/wide-attachment-type-attribute.html
M LayoutTests/platform/ios-wk2/TestExpectations
A
LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
A
LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M Source/WebCore/html/HTMLAttachmentElement.cpp
Log Message:
-----------
Add initial slew of tests for wide-layout attachment
https://bugs.webkit.org/show_bug.cgi?id=254203
rdar://106984208
Reviewed by Aditya Keerthi.
Most are copies of the non-"wide" tests.
Minor bugs were revealed and fixed:
- When setting/changing the top-level attachment's id or class (or even style)
attribute, it was copied to the inner attachment, possibly modifying its
rendering through css. So instead of indiscriminately copying every attribute,
only the necessary ones related to the icon/thumbnail display are now copied.
- setFile function calls on the top-level attachment needed to be forwarded to
the inner attachment to display the correct icon in some cases.
Render tree tests could become proper ref tests once the inner attachment is
replaced with a standard HTML image element.
* LayoutTests/TestExpectations:
* LayoutTests/fast/attachment/cocoa/wide-attachment-class-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-class.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon-expected.html:
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-default-icon.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-dom-expected.txt: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-dom.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon-expected.html:
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-folder-icon.html: Added.
*
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension-expected.html:
Added.
*
LayoutTests/fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html:
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-id-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-id.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-rendering.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-save-event-expected.txt:
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-save-event.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-uti-expected.html: Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-uti.html: Added.
*
LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action-expected-mismatch.html:
Added.
* LayoutTests/fast/attachment/cocoa/wide-attachment-wrapping-action.html: Added.
*
LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process-expected.html:
Added.
* LayoutTests/fast/attachment/mac/wide-attachment-element-gpu-process.html:
Added.
*
LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt:
Added.
* LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic.html:
Added.
* LayoutTests/fast/attachment/mac/wide-attachment-type-attribute-expected.html:
Added.
* LayoutTests/fast/attachment/mac/wide-attachment-type-attribute.html: Added.
* LayoutTests/platform/ios-wk2/TestExpectations:
*
LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
Added.
* LayoutTests/platform/mac-wk2/TestExpectations:
*
LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
Added.
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
When first constructed, only relevant attributes are copied into the inner
attachment.
(WebCore::HTMLAttachmentElement::setFile):
File details may be set through this function (instead of through element
attributes), so the call must be duplicated into the inner attachment.
(WebCore::HTMLAttachmentElement::parseAttribute):
When attributes are modified, only the ones relevant to the attachment display
are forwarded to the inner attachment.
Canonical link: https://commits.webkit.org/262067@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
