Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ed99b93877dd9c47942db5a0f56a82acc4adeebd
https://github.com/WebKit/WebKit/commit/ed99b93877dd9c47942db5a0f56a82acc4adeebd
Author: Patrick Angle <[email protected]>
Date: 2023-03-24 (Fri, 24 Mar 2023)
Changed paths:
M
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
M Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js
M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
M Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js
M Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
M Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js
Log Message:
-----------
Web Inspector: (Regression: 254636@main) Mini console always opens when
choosing "Inspect Element", even if it was previously closed
https://bugs.webkit.org/show_bug.cgi?id=253273
rdar://106260652
Reviewed by Devin Rousso.
When console snippets were introduced, the function signature of
`appendImmediateExecutionWithResult` was updated so
that optional values were part of an options object. However, in changing that
it appears it was assumed that the
default would be flipped to `false`, but that never happened. The parameter was
no longer being provided by DOMManger
when inspecting an element, and therefor we fell back to the default of showing
the quick console.
To fix this, we correct the `shouldRevealConsole` to be `false` by default,
matching other option objects, and then
clean up other places where we were assuming it would still be true (mostly
anywhere that a "Log [thing]" option was
present).
*
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
- Use the new options object of the ConsoleCommandResultMessage constructor.
* Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js:
- Make `shouldRevealConsole` part of an options object, and make it default to
false instead.
* Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
(WI.AnimationContentView.prototype._populateAnimationTargetButtonContextMenu):
(WI.AnimationContentView):
* Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype._populateCanvasElementButtonContextMenu):
* Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:
(WI.CanvasTreeElement.prototype.populateContextMenu):
* Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:
* Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js:
(WI.ObjectPreviewView.prototype._contextMenuHandler):
(WI.ObjectPreviewView):
* Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WI.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
(WI.ObjectTreeBaseTreeElement.prototype._logValue):
* Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._handleDrop):
* Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js:
(WI.WebSocketResourceTreeElement.prototype.populateContextMenu):
Canonical link: https://commits.webkit.org/262106@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
