Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d2490b20c7723522fa49719c8f48ded0fea99b7
https://github.com/WebKit/WebKit/commit/4d2490b20c7723522fa49719c8f48ded0fea99b7
Author: Wenson Hsieh <[email protected]>
Date: 2023-03-24 (Fri, 24 Mar 2023)
Changed paths:
A
LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup-expected.txt
A LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html
M
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp
Log Message:
-----------
[UI-Side Compositing] WebKit crashes when pressing Page Up/Fn Up key
https://bugs.webkit.org/show_bug.cgi?id=254453
rdar://107206783
Reviewed by Simon Fraser.
262105@main inadvertently changed the order in which a scrolling node's
`RequestedScrollData` and
`KeyboardScrollData` are decoded, but not the order in which they're encoded.
This means that if
both `RequestedScrollPosition` and `KeyboardScrollData` flags are set on a
state node, we'll end up
failing to decode the state node properly.
Fix this by correcting the order in which these two members are decoded.
Test: fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html
*
LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup-expected.txt:
Added.
* LayoutTests/fast/scrolling/mac/keyboard-scrolling-pagedown-pageup.html: Added.
*
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
Canonical link: https://commits.webkit.org/262110@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
