Branch: refs/heads/safari-7615.1.26.12-branch
Home: https://github.com/WebKit/WebKit
Commit: 917e1268090934256f6bfb2759c5271c88c5e9e7
https://github.com/WebKit/WebKit/commit/917e1268090934256f6bfb2759c5271c88c5e9e7
Author: Russell Epstein <[email protected]>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.12.1
Canonical link: https://commits.webkit.org/[email protected]
Commit: 2e9a40a5bf863fad6b8dccfdba7db65aafd8baae
https://github.com/WebKit/WebKit/commit/2e9a40a5bf863fad6b8dccfdba7db65aafd8baae
Author: Jer Noble <[email protected]>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
Log Message:
-----------
Cherry-pick 96230945f879. rdar://problem/94878533
CRASH: GPUP at -[WebCoreNSURLSessionDataTask _cancel]
https://bugs.webkit.org/show_bug.cgi?id=253044
rdar://94878533
Reviewed by Eric Carlson.
-[WebCoreNSURLSessionDataTask session] currently converts a WeakObjC
pointer (safely) into
a RetainPtr, then returns a raw pointer from that RetainPtr. The RetainPtr
is destroyed after
returning, which reduces the retain count. It is then stored into a
RetainPtr again by the
caller inside -_cancel;
Meanwhile, on another thread, the WebCoreNSURLSession can be released by
the system, leaving
an opportunity to release the WebCoreNSURLSession and reduce it's retain
count to zero in
between the two RetainPtr calls on the main thread, leading to the client
retaining a dealloc'd
object.
Instead, -session should return an autorelease()'d pointer, thereby
ensuring the session is
retained long enough for the client to retain it. This will increase
retain-count churn, but
will also guarantee the object cannot be destroyed on a background thread
while it's still
being used on the main thread.
* Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask session]):
Canonical link: https://commits.webkit.org/260941@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 16109320c5b56422f898eb56a080d94b99bea386
https://github.com/WebKit/WebKit/commit/16109320c5b56422f898eb56a080d94b99bea386
Author: Dan Robson <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.12.2
Identifier: [email protected]
Commit: 18b849bb81555d4022c4778f4ec19457d0e396cd
https://github.com/WebKit/WebKit/commit/18b849bb81555d4022c4778f4ec19457d0e396cd
Author: Matt Woodrow <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/html/OffscreenCanvas.cpp
Log Message:
-----------
Cherry-pick 630b1e2aa50f. rdar://problem/105684718
Disable main-thread WebGL in OffscreenCanvas.
https://bugs.webkit.org/show_bug.cgi?id=253267
<rdar://105684718>
Reviewed by Simon Fraser.
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::shouldEnableWebGL):
Canonical link: https://commits.webkit.org/259548.355@safari-7615-branch
Commit: 08c2e1ccf5dffbe12cb60d61ecf1ab230bf7cb90
https://github.com/WebKit/WebKit/commit/08c2e1ccf5dffbe12cb60d61ecf1ab230bf7cb90
Author: Russell Epstein <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/editing/ruby-with-edited-text-crash-expected.txt
A LayoutTests/fast/editing/ruby-with-edited-text-crash.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
Cherry-pick 6f9b18dfa549. rdar://problem/105848359
Cherry-pick 261063@main (02bb8ae9d573). rdar://problem/105848359
Make sure child is a RenderElement before trying to pass it into
shouldChildInlineMarginContributeToContainerIntrinsicSize in
RenderBlock::computeBlockPreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=253165
rdar://105848359
Reviewed by Alan Baradlay.
We should not be assuming that child is always doing to be a
RenderElement in this method. It can sometimes be a RenderText (like
in the attached test case), which will cause a nullptr dereference.
Instead, we should check the result of the dynamicDowncast before
passing it into
shouldChildInlineMarginContributeToContainerIntrinsicSize.
The only other change is that we use the default constructor for
startMarginLength and endMarginLength. This should be ok even if we do
not enter the code guarded by the if statement because the isFixed()
call will return false and not impact the margins.
* LayoutTests/TestExpectations:
* LayoutTests/fast/editing/ruby-with-edited-text-crash-expected.txt:
Added.
* LayoutTests/fast/editing/ruby-with-edited-text-crash.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths const):
Canonical link: https://commits.webkit.org/261063@main
Canonical link: https://commits.webkit.org/259548.371@safari-7615-branch
Commit: 828f445f3c3ac9b82c5af80eb4eb89ccbfbb1d4b
https://github.com/WebKit/WebKit/commit/828f445f3c3ac9b82c5af80eb4eb89ccbfbb1d4b
Author: Said Abou-Hallawa <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/platform/graphics/GraphicsContext.h
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp
Log Message:
-----------
Cherry-pick 841ab1df8b81. rdar://problem/106017462
Cherry-pick 9180e60fc30a. rdar://problem/106017462
REGRESSION(260512@main): HDR images should be drawn directly if the
destination context has HDR color space
https://bugs.webkit.org/show_bug.cgi?id=253275
rdar://106055782
Reviewed by Simon Fraser.
CoreGraphics should draw the HDR images directly to the destination
context if
it has HDR color space.
ImageBuffer::draw() should call
GraphicsContext::drawNativeImageInternal() to
prevent the possible recursion from NativeImage::draw() to
ImageBuffer::draw().
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawConsuming):
* Source/WebCore/platform/graphics/cg/NativeImageCG.cpp:
(WebCore::NativeImage::draw):
Canonical link: https://commits.webkit.org/261149@main
Commit: 072c3859b16f7dbdf8b68fddeaef46d051160ee6
https://github.com/WebKit/WebKit/commit/072c3859b16f7dbdf8b68fddeaef46d051160ee6
Author: Myah Cobbs <[email protected]>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/platform/graphics/GraphicsContext.h
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp
Log Message:
-----------
Revert "Cherry-pick 841ab1df8b81. rdar://problem/106017462"
This reverts commit 828f445f3c3ac9b82c5af80eb4eb89ccbfbb1d4b.
Canonical link: https://commits.webkit.org/[email protected]
Compare: https://github.com/WebKit/WebKit/compare/917e12680909%5E...072c3859b16f
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
