Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 05214ae00dbcb8c40ae470395f34556bd7fe61ce
https://github.com/WebKit/WebKit/commit/05214ae00dbcb8c40ae470395f34556bd7fe61ce
Author: Alan Baradlay <[email protected]>
Date: 2023-03-27 (Mon, 27 Mar 2023)
Changed paths:
A
LayoutTests/fast/inline/out-of-flow-inline-with-float-on-last-line-expected.html
A LayoutTests/fast/inline/out-of-flow-inline-with-float-on-last-line.html
M
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
M
Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
Log Message:
-----------
[IFC] Incorrect out-of-flow box placement when float is present (display:
inline)
https://bugs.webkit.org/show_bug.cgi?id=254539
Reviewed by Antti Koivisto.
"After the last line content" ((inline level)out-of-flow box positioned after
the last line with inflow content) should take floats into account.
(Pass in FloatingContext all the way to contentLeftAfterLastLine, so that we
can check if there's a float after the last line.)
*
LayoutTests/fast/inline/out-of-flow-inline-with-float-on-last-line-expected.html:
Added.
* LayoutTests/fast/inline/out-of-flow-inline-with-float-on-last-line.html:
Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::InlineFormattingContext::computeStaticPositionForOutOfFlowContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::contentLeftAfterLastLine const):
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox
const):
(WebCore::Layout::InlineFormattingGeometry::lineBoxOffsetAfterLastLine const):
Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:
Canonical link: https://commits.webkit.org/262189@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
