Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 76ecf9b7d9903dcd3d22e944fa0e0cbf450240af
https://github.com/WebKit/WebKit/commit/76ecf9b7d9903dcd3d22e944fa0e0cbf450240af
Author: Chris Fleizach <cfleiz...@apple.com>
Date: 2023-03-31 (Fri, 31 Mar 2023)
Changed paths:
R
LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt
R
LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html
M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
Log Message:
-----------
Bug 254830 - AX: remove shouldIgnoreGroup checks
https://bugs.webkit.org/show_bug.cgi?id=254830
rdar://107478003
Reviewed by Tyler Wilcock.
In shouldIgnoreGroup, we check if a group has an aria name that matches the
text inside to avoid duplication.
However, when we do this work at the wrong time (during layout), calling
textUnderElement() leads to asserts being hit.
There's no good way to do both of these things, so removing this heuristic
seems like a better approach with the team.
*
LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt:
Removed.
*
LayoutTests/accessibility/mac/ignore-redundant-accessibility-text-groups.html:
Removed.
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
(WebCore::shouldIgnoreGroup): Deleted.
Canonical link: https://commits.webkit.org/262456@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
