Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 12441d93d8c3ea03464c5473548dd6c98203bba9
https://github.com/WebKit/WebKit/commit/12441d93d8c3ea03464c5473548dd6c98203bba9
Author: Per Arne Vollan <[email protected]>
Date: 2023-04-07 (Fri, 07 Apr 2023)
Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
Log Message:
-----------
Vimeo video goes black if you hit the in-website play button while the video
is open in PiP
https://bugs.webkit.org/show_bug.cgi?id=255163
rdar://107592139
Reviewed by Simon Fraser.
Vimeo enters fullscreen when starting playback from the inline play button
while already in PIP.
This behavior is revealing a bug in the fullscreen handling. This patch
introduces a quirk to
work around this issue. This patch also reverts
<https://commits.webkit.org/262703@main> since
it did not resolve the issue.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::blocksEnteringStandardFullscreenFromPictureInPictureQuirk
const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
(VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h:
(WebKit::VideoFullscreenManager::videoElementInPictureInPicture const):
Canonical link: https://commits.webkit.org/262723@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
