Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3ac8b5512c4dd0473a576ad26d5682c93ee1f721
https://github.com/WebKit/WebKit/commit/3ac8b5512c4dd0473a576ad26d5682c93ee1f721
Author: Matthieu Dubet <[email protected]>
Date: 2023-04-12 (Wed, 12 Apr 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-03.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-06.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-09.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-12.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-15.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-18.html
M Source/WebCore/platform/text/TextFlags.cpp
Log Message:
-----------
Use String::isNull instead of std::optional<String>
https://bugs.webkit.org/show_bug.cgi?id=255337
rdar://107758556
Reviewed by Brent Fulgham.
std::optional<String> doesn't make sense because String
has its own representation of invalid (isNull).
In this case, the optional check was always true, thus
passing a null string to the find() method.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-03.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-06.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-09.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-12.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-15.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-alternates-18.html:
* Source/WebCore/platform/text/TextFlags.cpp:
(WebCore::computeFeatureSettingsFromVariants):
Canonical link: https://commits.webkit.org/262880@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
