Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 64065c28f61d71c2dfff6e6fa5e1ffb7d0b180d5
https://github.com/WebKit/WebKit/commit/64065c28f61d71c2dfff6e6fa5e1ffb7d0b180d5
Author: Philippe Normand <ph...@igalia.com>
Date: 2023-04-21 (Fri, 21 Apr 2023)
Changed paths:
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h
Log Message:
-----------
[GStreamer][MediaStream] fast/mediastream/getDisplayMedia-size.html hits
ASSERT in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=255485
Reviewed by Xabier Rodriguez-Calvar.
The crash was happening because the mock display source was reporting an empty
size. Proxying the
size accessor to the underlying mock video source fixed that issue, but then
the video presets
handling also needed customization, because the mock display source provides no
preset, those are
specific to camera capture sources, so the mock display source can't use the
mock video capture
source presets and has to report an empty presets list.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
*
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
Canonical link: https://commits.webkit.org/263240@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
