Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6892f51e01e4ae5859637a6cc2f615f7af92a76
      
https://github.com/WebKit/WebKit/commit/b6892f51e01e4ae5859637a6cc2f615f7af92a76
  Author: Ryosuke Niwa <[email protected]>
  Date:   2023-04-22 (Sat, 22 Apr 2023)

  Changed paths:
    A LayoutTests/editing/selection/selection-toString-input-expected.txt
    A LayoutTests/editing/selection/selection-toString-input.html
    A LayoutTests/editing/selection/selection-toString-textarea-expected.txt
    A LayoutTests/editing/selection/selection-toString-textarea.html
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt
    M Source/WebCore/page/DOMSelection.cpp

  Log Message:
  -----------
  REGRESSION (259904@main): window.getSelection() is empty for selection inside 
textarea
https://bugs.webkit.org/show_bug.cgi?id=252281

Reviewed by Wenson Hsieh.

Restore the pre-259904@main behavior of getSelection().toString(), which is to 
return
the string selected within input and textarea elements. This behavior is 
consistent with Chrome.

The post-259904@main behavior of not including the selected string within input 
and textarea
elements are consistent with Firefox but this turned out to be not Web 
compatible with at least
one Apple internal website.

* LayoutTests/editing/selection/selection-toString-input-expected.txt: Added.
* LayoutTests/editing/selection/selection-toString-input.html: Added.
* LayoutTests/editing/selection/selection-toString-textarea-expected.txt: Added.
* LayoutTests/editing/selection/selection-toString-textarea.html: Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt:
 Rebaselined.
* Source/WebCore/page/DOMSelection.cpp:
(WebCore::DOMSelection::toString const):

Canonical link: https://commits.webkit.org/263280@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to