Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1643a89b579b0a44284018d1506f83090fd76a26
https://github.com/WebKit/WebKit/commit/1643a89b579b0a44284018d1506f83090fd76a26
Author: Rob Buis <[email protected]>
Date: 2023-04-24 (Mon, 24 Apr 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html
M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
M Source/WebCore/css/calc/CSSCalcOperationNode.h
Log Message:
-----------
css/css-values/hypot-pow-sqrt-computed.html WPT crashes
https://bugs.webkit.org/show_bug.cgi?id=254392
Reviewed by Tim Nguyen.
When simplifying hypot CSSCalcOperationNodes we may have only one child and
it may not be a CSSCalcPrimitiveValueNode, in that case do not simplify.
Add a similar check and tests for round, mod and rem.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html:
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::combineChildren):
* Source/WebCore/css/calc/CSSCalcOperationNode.h:
Canonical link: https://commits.webkit.org/263345@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
