Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 448487f4e635fac0719e05793ab6fba164ae361a
https://github.com/WebKit/WebKit/commit/448487f4e635fac0719e05793ab6fba164ae361a
Author: Michael Catanzaro <[email protected]>
Date: 2023-04-28 (Fri, 28 Apr 2023)
Changed paths:
M Source/WTF/wtf/FileSystem.h
M Source/WTF/wtf/PlatformGTK.cmake
M Source/WTF/wtf/PlatformWPE.cmake
M Source/WTF/wtf/glib/FileSystemGlib.cpp
M Source/WTF/wtf/posix/FileSystemPOSIX.cpp
M Source/cmake/OptionsCommon.cmake
Log Message:
-----------
[GLib] Lobotomize FileSystemGlib.cpp
https://bugs.webkit.org/show_bug.cgi?id=255932
Reviewed by Carlos Garcia Campos.
Most of FileSystemGlib.cpp is redundant with FileSystemPOSIX.cpp. There
is no good reason to implement the POSIX-style WTF::Filesystem APIs
using GIO when we have access to POSIX. FileSystemGlib.cpp nowadays goes
to rather extreme lengths to work around impedance between the GIO and
POSIX APIs, and it's much simpler to just use POSIX.
* Source/WTF/wtf/FileSystem.h:
* Source/WTF/wtf/PlatformGTK.cmake:
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/glib/FileSystemGlib.cpp:
(WTF::FileSystemImpl::stringFromFileSystemRepresentation): Deleted.
(WTF::FileSystemImpl::fileSystemRepresentation): Deleted.
(WTF::FileSystemImpl::genericGIOFileClose): Deleted.
(WTF::FileSystemImpl::genericGIOFileQueryInfo): Deleted.
(WTF::FileSystemImpl::genericGIOGetInputStream): Deleted.
(WTF::FileSystemImpl::genericGIOGetOutputStream): Deleted.
(WTF::FileSystemImpl::genericGIOGetFileDescriptorBased): Deleted.
(WTF::FileSystemImpl::posixFileDescriptor): Deleted.
(WTF::FileSystemImpl::fileSize): Deleted.
(WTF::FileSystemImpl::fileID): Deleted.
(WTF::FileSystemImpl::fileIDsAreEqual): Deleted.
(WTF::FileSystemImpl::fileCreationTime): Deleted.
(WTF::FileSystemImpl::openTemporaryFile): Deleted.
(WTF::FileSystemImpl::openFile): Deleted.
(WTF::FileSystemImpl::closeFile): Deleted.
(WTF::FileSystemImpl::seekFile): Deleted.
(WTF::FileSystemImpl::truncateFile): Deleted.
(WTF::FileSystemImpl::flushFile): Deleted.
(WTF::FileSystemImpl::writeToFile): Deleted.
(WTF::FileSystemImpl::readFromFile): Deleted.
(WTF::FileSystemImpl::getFileDeviceId): Deleted.
(WTF::FileSystemImpl::volumeFileBlockSize): Deleted.
(WTF::FileSystemImpl::lockFile): Deleted.
(WTF::FileSystemImpl::unlockFile): Deleted.
* Source/WTF/wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::fileCreationTime):
(WTF::FileSystemImpl::temporaryFileDirectory):
(WTF::FileSystemImpl::openTemporaryFile):
* Source/cmake/OptionsCommon.cmake:
Canonical link: https://commits.webkit.org/263503@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
