Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c5c4b9c561811faabfb7148569c71d58ea9f58ac
https://github.com/WebKit/WebKit/commit/c5c4b9c561811faabfb7148569c71d58ea9f58ac
Author: Rob Buis <[email protected]>
Date: 2023-04-29 (Sat, 29 Apr 2023)
Changed paths:
M LayoutTests/fast/events/focus-label-legend-elements-with-tab-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable.html
R
LayoutTests/platform/glib/fast/events/focus-label-legend-elements-with-tab-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
M
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
M
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
M Source/WebCore/html/HTMLFormControlElement.cpp
Log Message:
-----------
[popover] Improve focus handling
https://bugs.webkit.org/show_bug.cgi?id=255454
Reviewed by Ryosuke Niwa.
A lot of tests are failing because on macOS buttons are not considered to be
focusable.
Start allowing this in case tabindex is set on form controls and adjust the
tests accordingly.
* LayoutTests/fast/events/focus-label-legend-elements-with-tab-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable.html:
*
LayoutTests/platform/glib/fast/events/focus-label-legend-elements-with-tab-expected.txt:
Removed.
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
*
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
*
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
*
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isKeyboardFocusable const):
(WebCore::HTMLFormControlElement::isMouseFocusable const):
Canonical link: https://commits.webkit.org/263527@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
