Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ef3f34692b73ffde48adf3a63a2d64b204929402
https://github.com/WebKit/WebKit/commit/ef3f34692b73ffde48adf3a63a2d64b204929402
Author: Wenson Hsieh <[email protected]>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-expected.txt
M
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-frame-expected.txt
M
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html
M
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable.html
Log Message:
-----------
editing/selection/ios/hide-selection-in-hidden-contenteditable.html times out
on some test runners
https://bugs.webkit.org/show_bug.cgi?id=256608
rdar://107725234
Reviewed by Ryosuke Niwa.
This patch contains a couple of speculative fixes for this failing test, along
with some logging to
help diagnose the test failure in case the speculative fixes don't work. I
suspect that this is due
to the prior test,
`editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html`,
ending too early (just as the keyboard is about to appear). Address this by
cleaning up this
previous test so that it waits for the keyboard to appear and then disappear
before ending, by
adding a missing `await` in the `waitForSelectionChangeInSubframe` helper
function.
We also sprinkle some `console.log` messages throughout both tests, so that
even if the test times
out, we'll be able to observe how far along it got.
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-expected.txt:
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-frame-expected.txt:
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html:
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-contenteditable.html:
Canonical link: https://commits.webkit.org/263936@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
