Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ec60ea32b263b02ba212296b8cbccf8d45007038
https://github.com/WebKit/WebKit/commit/ec60ea32b263b02ba212296b8cbccf8d45007038
Author: Tadeu Zagallo <[email protected]>
Date: 2023-05-15 (Mon, 15 May 2023)
Changed paths:
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.h
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/ShaderModule.mm
Log Message:
-----------
[WebGPU] Report errors instead of crashing when shader compilation fails
https://bugs.webkit.org/show_bug.cgi?id=256719
rdar://109270536
Reviewed by Mike Wyrzykowski and Dan Glastonbury.
Handle the errors that arise as a consequence of shader compilation failure:
- invalid BindGroupLayout in createBindGroup (when trying to use the generated
auto layout)
- invalid pipeline in (Compute|Render)PassEncoder::setPipeline (as a consequence
of the invalid BindGroup)
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::makeInvalid):
(WebGPU::ComputePassEncoder::setPipeline):
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::makeInvalid):
(WebGPU::RenderPassEncoder::setPipeline):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):
Canonical link: https://commits.webkit.org/264065@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
