Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 347111d578a4171bc5ef8b5917ba41c4c22acc59
https://github.com/WebKit/WebKit/commit/347111d578a4171bc5ef8b5917ba41c4c22acc59
Author: Devin Rousso <[email protected]>
Date: 2023-05-17 (Wed, 17 May 2023)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/FindBanner.css
M Source/WebInspectorUI/UserInterface/Views/FindBanner.js
M Source/WebInspectorUI/UserInterface/Views/LogContentView.css
M Source/WebInspectorUI/UserInterface/Views/LogContentView.js
Log Message:
-----------
Web Inspector: REGRESSION(?): Console: find results count has no left padding
https://bugs.webkit.org/show_bug.cgi?id=256531
Reviewed by Patrick Angle.
* Source/WebInspectorUI/UserInterface/Views/FindBanner.css:
(.find-banner):
(.find-banner > input[type="search"]):
(.find-banner > button):
(.find-banner > button.segmented):
(.find-banner > label):
(.find-banner > label:not(:empty)): Added.
(.find-banner > :first-child): Deleted.
(.find-banner > :last-child): Deleted.
(.find-banner.console-find-banner): Deleted.
(body .find-banner.console-find-banner): Deleted.
(.find-banner.console-find-banner > input[type="search"]): Deleted.
(body[dir=ltr] .find-banner.console-find-banner > input[type="search"]):
Deleted.
(body[dir=rtl] .find-banner.console-find-banner > input[type="search"]):
Deleted.
(.find-banner.console-find-banner > :is(input[type="search"], button)): Deleted.
(.find-banner.console-find-banner >
input[type="search"]::-webkit-textfield-decoration-container): Deleted.
(.find-banner.console-find-banner > input[type="search"]:focus,
.find-banner.console-find-banner > input[type="search"]:focus ~ button,
.find-banner.console-find-banner >
input[type="search"]:not(:placeholder-shown), .find-banner.console-find-banner
> input[type="search"]:not(:placeholder-shown) ~ button): Deleted.
* Source/WebInspectorUI/UserInterface/Views/LogContentView.css:
(.navigation-bar > .item.find-banner.console): Added.
(:not(.console-drawer) > .navigation-bar > .item.find-banner.console): Added.
(.navigation-bar > .item.find-banner.console > input[type="search"]): Added.
(.navigation-bar > .item.find-banner.console > :is(input[type="search"],
button)): Added.
(.navigation-bar > .item.find-banner.console >
input[type="search"]::-webkit-textfield-decoration-container): Added.
(.navigation-bar > .item.find-banner.console > input[type="search"]:focus,
.navigation-bar > .item.find-banner.console > input[type="search"]:focus ~
button, .navigation-bar > .item.find-banner.console >
input[type="search"]:not(:placeholder-shown), .navigation-bar >
.item.find-banner.console > input[type="search"]:not(:placeholder-shown) ~
button ): Added.
(.console-find-banner): Deleted.
Avoid using `:first-child`/`:last-child` (and `!important`) as they have very
little control over what kinds of situations they apply (e.g. we don't want to
add padding to `label:empty`).
Don't add any outside `margin` as that's handled by the containing
`WI.NavigationBar` (or adjacent `WI.NavigationItem`) unless we know for sure
that it's the first/last `WI.NavigationItem` in the `WI.NavigationBar`.
Drive-by: Move styles to a more relevant location.
* Source/WebInspectorUI/UserInterface/Views/FindBanner.js:
(WI.FindBanner):
* Source/WebInspectorUI/UserInterface/Views/LogContentView.js:
(WI.LogContentView):
Drive-by: Rework optional parameters into `{...} = {}` to match existing
pattern elsewhere.
Canonical link: https://commits.webkit.org/264167@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
